Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex(rpc): implement candlestick streaming #4475

Closed
erwanor opened this issue May 24, 2024 · 1 comment
Closed

dex(rpc): implement candlestick streaming #4475

erwanor opened this issue May 24, 2024 · 1 comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@erwanor
Copy link
Member

erwanor commented May 24, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label May 24, 2024
@erwanor
Copy link
Member Author

erwanor commented May 24, 2024

Sorry misclicked before writing the description, editing

@hdevalence hdevalence mentioned this issue May 24, 2024
Merged
1 task
erwanor pushed a commit that referenced this issue May 28, 2024
@hdevalence
dex: implement streaming candlesticks like compact blocks (#4476)
36081ff 
## Describe your changes

Fill in the streaming notification RPC for candlestick data.

This also rearranges some of the existing code to split out the
component parts from the data modeling parts.

In the future, we could add more metrics or consider writing something
generic for this pattern of "subscribe and pull out of state", though it
might not make sense until we have a third API since this one is already
different from the compact block RPC (where there's a catch up phase).
But that could be a good way to do things like per-RPC connection
counters. Or perhaps that should better not be done "inside" each
streaming RPC but as a middleware that could be on any streaming RPC.

## Issue ticket number and link

#4475

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

> no changes to consensus logic, only mechanical refactoring and RPC
cahnges
@erwanor erwanor closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Penumbra
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erwanor