Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce BlockParams::max_bytes #4595

Closed
dynst opened this issue Jun 12, 2024 · 0 comments · Fixed by #4597
Closed

Reduce BlockParams::max_bytes #4595

dynst opened this issue Jun 12, 2024 · 0 comments · Fixed by #4597
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@dynst
Copy link
Contributor

dynst commented Jun 12, 2024 •
edited
Loading

cometbft/cometbft#1518

CometBFT lowered the default value for BlockParams.MaxBytes from 21MiB to 4MiB, after last year's ASA-2023-002.
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 12, 2024
dynst added a commit to dynst/penumbra that referenced this issue Jun 12, 2024
@dynst
Reduce block size max_bytes to 4MiB
4c44b8b 
This matches the new default upstream. Closes penumbra-zone#4595.

See also cometbft/cometbft#1518
@dynst dynst mentioned this issue Jun 12, 2024
Merged
1 task
erwanor added a commit that referenced this issue Jun 13, 2024
@dynst @erwanor
pd: configure cometbft with max_bytes to 1MiB (#4597)
ba89445 
## Describe your changes

Reduce `tendermint::block::Size::max_bytes` from 21MiB to 1MiB.

## Issue ticket number and link
Closes #4595

## Checklist before requesting a review

- [X] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

Consensus parameters are not part of consensus but could affect network
liveness.

---------

Signed-off-by: Erwan Or <erwan.ounn.84@gmail.com>
Co-authored-by: Erwan Or <erwan.ounn.84@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Penumbra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pd: configure cometbft with max_bytes to 1MiB dynst/penumbra
1 participant
@dynst