-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor default_order. #16
Conversation
Missing tests around order reverse (perhaps another story): as an example |
Missing tests when |
Former |
Missing notes in CHANGELOG. |
I'll make a ticket for default_order can make a list or a string and remove order_reverse. |
Then how do you manage the order arrow? |
Have you checked the demo project? Does it explain the usage of default_order? |
self.assertEqual(queryset.query.order_by, ['last_name']) | ||
|
||
def test_default_order_form_invalid(self): | ||
"""Queryset is ordered by default_order when no order_by in request.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and form is invalid
Merge order_by_list and default_order.