Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uri model #29

Merged
merged 16 commits into from
Mar 28, 2017
Merged

add uri model #29

merged 16 commits into from
Mar 28, 2017

Conversation

pepegar
Copy link
Owner

@pepegar pepegar commented Mar 16, 2017

Introduces a Uri class that will be used on the high level API.

Waiting for atto to be cross-compiled to ScalaJS, since we're using at our very core right now. Done now :)

TODO:

  • tests for toString (will be used to translate to the raw string that the low level uses.
  • integrate on hi

closes #26

@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #29 into master will decrease coverage by 0.32%.
The diff coverage is 70.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   82.49%   82.16%   -0.33%     
==========================================
  Files          15       16       +1     
  Lines         297      314      +17     
  Branches        2        4       +2     
==========================================
+ Hits          245      258      +13     
- Misses         52       56       +4
Impacted Files Coverage Δ
core/shared/src/main/scala/hammock/hi/dsl.scala 37.5% <ø> (+1.13%) ⬆️
.../src/main/scala/hammock/jvm/free/Interpreter.scala 90.47% <100%> (ø) ⬆️
core/shared/src/main/scala/hammock/hi/Opts.scala 71.42% <33.33%> (ø) ⬆️
...e/shared/src/main/scala/hammock/free/algebra.scala 44.44% <50%> (ø) ⬆️
core/shared/src/main/scala/hammock/Hammock.scala 72% <69.56%> (-0.42%) ⬇️
core/shared/src/main/scala/hammock/Uri.scala 70.83% <70.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f7253...dc1b5fc. Read the comment docs.

@pepegar pepegar merged commit 3a54a9f into master Mar 28, 2017
@pepegar pepegar deleted the uri branch March 28, 2017 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URI class
1 participant