Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for latest GHC. #10

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

sighingnow
Copy link
Contributor

Fixes for latest GHC and monad-control package.

Besides, could you please help to publish a new release of this package on hackage to make it usable with latest GHC (since this package is depended by other packages)?

@sighingnow
Copy link
Contributor Author

/cc @pepeiborra Just in case that you don't receive notification about this PR.

@pepeiborra
Copy link
Owner

Thank you, this is awesome!
Let me quickly set up some Github Actions for continuous integration to validate the changes.

@pepeiborra
Copy link
Owner

Could you rebase and force push?

Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
@sighingnow
Copy link
Contributor Author

Hi @pepeiborra All ci suites are green now!

Copy link
Owner

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks

@pepeiborra pepeiborra merged commit 693938c into pepeiborra:master Jul 6, 2020
@sighingnow sighingnow deleted the ht/fix-for-latest-ghc branch July 6, 2020 06:55
@sighingnow
Copy link
Contributor Author

Thanks for merging and cutting the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants