Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new idea: sample_filters #338

Open
nsheff opened this issue Mar 4, 2020 · 3 comments
Open

new idea: sample_filters #338

nsheff opened this issue Mar 4, 2020 · 3 comments

Comments

@nsheff
Copy link
Contributor

nsheff commented Mar 4, 2020

the sample_filters section lets you filter which samples are included.
it would behave like imply, sort of, but instead of adding new attributes, takes some samples out of consideration.

@stolarczyk
Copy link
Member

isn't that exactly what selector functionality does in looper?

select samples:
  This group of arguments lets you specify samples to use by exclusion OR
  inclusion of the samples attribute values.

  --selector-attribute SELECTOR_ATTRIBUTE
                        Specify the attribute for samples exclusion OR
                        inclusion
  --selector-exclude [SELECTOR_EXCLUDE [SELECTOR_EXCLUDE ...]]
                        Operate only on samples that either lack this
                        attribute value or for which this value is not in this
                        collection.
  --selector-include [SELECTOR_INCLUDE [SELECTOR_INCLUDE ...]]
                        Operate only on samples associated with these
                        attribute values; if not provided, all samples are
                        used.

do you suggest to move this functionality to peppy?

@nsheff
Copy link
Contributor Author

nsheff commented Mar 5, 2020

yes that is a great way to put it!

maybe not worth thinking about. what do you think? this is not high priority...

@nsheff
Copy link
Contributor Author

nsheff commented May 4, 2020

it could work like this:

project_modifiers:
  filter:
    - attribute: protocol
      include: ["ATAC-seq"]
      exclude: ["RNA-seq"]

for each attribute, you have to have either an include, or an exclude, or both.
if multiple values are listed under 'include/exclude', it ORs them.
if multiple attributes are listed, it ANDs them? Or, disallow multiple attributes.

looper selectors could then just offer a CLI interface to override this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants