Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve is not using the pipestatmanager object record_identifier if none is supplied #175

Closed
donaldcampbelljr opened this issue Apr 4, 2024 · 1 comment
Labels
bug Something isn't working likely-solved
Milestone

Comments

@donaldcampbelljr
Copy link
Contributor

          Regarding 

why can't retrieve use the class record identifier?

With the above example, psm.retrieve_one("value") , pipestat thinks that value is the record_identifier.

image

However, if I attempt to specify the arguments, result = psm.retrieve_one(result_identifier="value"), I see that there is a problem and pipestat is not pulling the class record_identifier appropriately.

psm1 = PipestatManager(record_identifier="RECORD1", schema_path="sample_output_schema.yaml", results_file_path="results.yaml", pipeline_type="sample")
psm1.report(values={"number_of_things": 100})
result = psm1.retrieve_one(result_identifier="number_of_things")

Error

  File "/home/drc/PythonProjects/pipestat/opt_dependencies/venv6/lib/python3.10/site-packages/pipestat/pipestat.py", line 708, in retrieve_one
    raise RecordNotFoundError(
pipestat.exceptions.RecordNotFoundError: Results '['number_of_things']' for 'None' not found

Originally posted by @donaldcampbelljr in #158 (comment)

@donaldcampbelljr donaldcampbelljr added the bug Something isn't working label Apr 4, 2024
@donaldcampbelljr donaldcampbelljr added this to the v0.9.0 milestone Apr 15, 2024
@donaldcampbelljr
Copy link
Contributor Author

This is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working likely-solved
Projects
None yet
Development

No branches or pull requests

1 participant