-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dependency from mtdowling/cron-expression to dragonmantank/cron-expression #47
Comments
@vincent-guesnard thank you for the appreciation and for the heads up. I currently have one open PR ready to be merged, I am holding off though, the reason is dragonmantank/cron-expression requires Bottom line is that I have to make a major release and increase the required php version to 7, it's kind of a big change to drop support for php < 7. I'll keep the PR open, any comment is more than welcome! |
Hi. First of all, thanks for your amazing work. I'm using Just wanted to up this issue. I think everyone is ready to move to |
+1 |
Thanks for a great lib! I can join the choir of PHP7 ;) |
+1 |
2 similar comments
+1 |
+1 |
Hello,
Thanks you for all this work. It's awesome.
Are you aware that mtdowling/cron-expression is falling ? According to http://ctankersley.com/2017/10/12/cron-expression-update/ , it seems there is a complete rewrite.
The prototype of CronExpression::factory seems to remain the same in the new project (dragonmantank/cron-expression)
OLD : https://github.com/mtdowling/cron-expression/blob/master/src/Cron/CronExpression.php
NEW : https://github.com/dragonmantank/cron-expression/blob/master/src/Cron/CronExpression.php
I guess there is no problem to update your composer.json to replace "mtdowling/cron-expression": "~1.0" by "dragonmantank/cron-expression/": "~2.0"
Best regards
Vincent
The text was updated successfully, but these errors were encountered: