Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of the advertising API to v2 #1

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Update use of the advertising API to v2 #1

merged 2 commits into from
Nov 12, 2018

Conversation

DavidAntaramian
Copy link

This updates the version of the advertising API to v2. Only GET operations have been updated along with the POST operations for the snapshotting and reporting endpoints.

The remaining POST, PUT, and DELETE operations have not been updated and may fail due to version inconsistencies.

This updates the version of the advertising API to v2. Only `GET`
operations have been updated along with the `POST` operations for the
snapshotting and reporting endpoints.

The remaining `POST`, `PUT`, and `DELETE` operations have _not_ been
updated and may fail due to version inconsistencies.
This commit makes sure that the new `campaign_type` parameters are added to the
end of the parameters list. This accounts for users that were using positional
arguments and not keyword arguments.
@fertel fertel merged commit 8ddf2d0 into master Nov 12, 2018
@fertel fertel deleted the update-to-api-v2 branch November 12, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants