Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ps 8.0.20 merge myrocks tokudb #2

Open
wants to merge 17 commits into
base: ps-8.0.20-merge
Choose a base branch
from

Commits on May 5, 2020

  1. PS-6789 (Merge MySQL 8.0.20): Reverted PS-3822 (InnoDB system tablesp…

    …ace encryption)
    
    https://jira.percona.com/browse/PS-6789
    
    Temporarily reverted PS-3822 "InnoDB system tablespace encryption"
    https://jira.percona.com/browse/PS-3822
    (commit 78b6114)
    to make parallel doublewrite part of the upstream 8.0.20 merge easier.
    
    Temporarily disabled the following MTR test cases:
    - 'innodb.percona_parallel_dblwr_encrypt'
    - 'innodb.percona_sys_tablespace_encrypt'
    - 'innodb.percona_sys_tablespace_encrypt_dblwr'
    - 'sys_vars.innodb_parallel_dblwr_encrypt_basic'
    - 'sys_vars.innodb_sys_tablespace_encrypt_basic'
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    71020ff View commit details
    Browse the repository at this point in the history
  2. PS-6789 (Merge MySQL 8.0.20): Reverted PS-3411 (Prevent creation of x…

    …b_doublewrite file when innodb_doublewrite is disabled)
    
    https://jira.percona.com/browse/PS-6789
    
    Temporarily reverted PS-3411 "LP #1570682: Parallel doublewrite buffer file created when skip-innodb_doublewrite is set"
    https://jira.percona.com/browse/PS-3411
    (commit 14318e4)
    to make parallel doublewrite part of the upstream 8.0.20 merge easier.
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    806f712 View commit details
    Browse the repository at this point in the history
  3. PS-6789 (Merge MySQL 8.0.20): Reverted PS-5678 (Parallel doublewrite …

    …must crash server on I/O error)
    
    https://jira.percona.com/browse/PS-6789
    
    Temporarily reverted PS-5678 "Parallel doublewrite must crash server on I/O error"
    https://jira.percona.com/browse/PS-5678
    (commit 0f810d7)
    to make parallel doublewrite part of the upstream 8.0.20 merge easier.
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    2df2ffb View commit details
    Browse the repository at this point in the history
  4. PS-6789 (Merge MySQL 8.0.20): Partially reverted PS-3829 (Innodb key …

    …rotation. ALPHA)
    
    https://jira.percona.com/browse/PS-6789
    
    Temporarily reverted 'buf0dblwr.cc' part of the PS-3829 "Innodb key rotation. ALPHA"
    https://jira.percona.com/browse/PS-3829
    (commit c7f44ee)
    to make parallel doublewrite part of the upstream 8.0.20 merge easier.
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    00ff76e View commit details
    Browse the repository at this point in the history
  5. PS-6789 (Merge MySQL 8.0.20): Reverted PS-1068 (Fix bug 1669414 Faile…

    …d to set O_DIRECT on xb_doublewrite when running MTR test cases)
    
    https://jira.percona.com/browse/PS-6789
    
    Temporarily reverted PS-1068 "Fix bug 1669414 (Failed to set O_DIRECT on xb_doublewrite when running MTR test cases)"
    https://jira.percona.com/browse/PS-1068
    (commit 7f41824)
    to make parallel doublewrite part of the upstream 8.0.20 merge easier.
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    f83833a View commit details
    Browse the repository at this point in the history
  6. PS-6789 (Merge MySQL 8.0.20): Reverted PS-1707 (Fix bug 1578139 Paral…

    …lel doublewrite memory not freed with innodb_fast_shutdown=2)
    
    https://jira.percona.com/browse/PS-6789
    
    Temporarily reverted PS-1707 "LP #1578139: Parallel doublewrite memory not freed with innodb_fast_shutdown=2"
    https://jira.percona.com/browse/PS-1707
    (commit 8a53ed7)
    to make parallel doublewrite part of the upstream 8.0.20 merge easier.
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    07becb3 View commit details
    Browse the repository at this point in the history
  7. PS-6789 (Merge MySQL 8.0.20): Reverted parallel-doublewrite blueprint…

    … implementation (Implement parallel doublewrite)
    
    https://jira.percona.com/browse/PS-6789
    
    Reverted 'parallel-doublewrite' blueprint implementation "Implement parallel doublewrite"
    https://blueprints.launchpad.net/percona-server/+spec/parallel-doublewrite
    (commit 4596aaa)
    to make parallel doublewrite part of the upstream 8.0.20 merge easier.
    
    Temporarily disabled the following MTR test cases:
    - 'sys_vars.innodb_parallel_doublewrite_path_basic'
    - 'innodb.percona_doublewrite'
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    58d29d2 View commit details
    Browse the repository at this point in the history
  8. Implemented PS-6789 (Merge MySQL 8.0.20) (docs)

    https://jira.percona.com/browse/PS-6789
    
    ***
    Updated man pages from MySQL Server 8.0.20 source tarball.
    
    ***
    Updated 'scripts/fill_help_tables.sql' from MySQL Server 8.0.20 source
    tarball.
    percona-ysorokin committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0354611 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    77e34ef View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Implemented PS-6789 (Merge MySQL 8.0.20) (conflicts resolved)

    https://jira.percona.com/browse/PS-6789
    
    ***
    Reverted our fix for PS-6094
    "Handler fails to trigger on Error 1049 or SQLSTATE 42000 or plain sqlexception"
    (https://jira.percona.com/browse/PS-6094)
    (commit 31b5c73)
    in favor of the upstream fix for the Bug #30561920 / #97682
    "Handler fails to trigger on Error 1049 or SQLSTATE 42000 or plain sqlexception"
    (https://bugs.mysql.com/bug.php?id=97682)
    (commit mysql/mysql-server@72c6171).
    
    ***
    Reverted our fix for PS-3630
    "LP #1660255: Test innodb.innodb_mysql is unstable"
    (https://jira.percona.com/browse/PS-3630)
    (commit e0b5050)
    in favor of the upstream fix for the Bug #30810572
    "FIX INNODB-MYSQL TEST"
    (commit mysql/mysql-server@2692669).
    
    ***
    Reverted our 8.0.17 merge postfix
    "PS-5363 (Merge MySQL 8.0.17): fixed regexps in the rpl.rpl_perfschema_threads_processlist_status MTR test case"
    (https://jira.percona.com/browse/PS-5363)
    (commit 8d7dd4a)
    affecting 'rpl.rpl_perfschema_threads_processlist_status' MTR test case
    in favor of the changes made by upstream in WL#3549
    "Binlog Compression"
    (commit mysql/mysql-server@1e5ae34).
    
    ***
    Reverted our 8.0.18 merge postfix
    "PS-5674: gen_lex_token generator reworked"
    (https://jira.percona.com/browse/PS-5674)
    (commit 214212a)
    in favor of the changes made by upstream Bug #30765691
    "FREE TOKEN SLOTS ARE EXHAUSTED IN GEN_LEX_TOKEN.CC"
    (commit mysql/mysql-server@17ca03f).
    'SYM_PERCONA()' macro preserved and made a synonym for upstream's 'SYM()'.
    Percona Server 5.7-specific tokens
    - CHANGED_PAGE_BITMAPS_SYM
    - CLIENT_STATS_SYM
    - CLUSTERING_SYM
    - COMPRESSION_DICTIONARY_SYM
    - INDEX_STATS_SYM
    - TABLE_STATS_SYM
    - THREAD_STATS_SYM
    - USER_STATS_SYM
    - ENCRYPTION_KEY_ID_SYM
    explicitly assigned values starting from 1300. The same values were assigned
    to them implicitly in Percona Server 8.0.19.
    Percona Server 8.0-specific tokens
    - EFFECTIVE_SYM
    - SEQUENCE_TABLE_SYM
    explicitly assigned values starting from 1350. This group has different values
    than in Percona Server 8.0.19.
    
    ***
    Similarly to other 'innodb.log_encrypt_<n>' MTR test cases 'innodb.log_encrypt_7'
    coming from upstream 8.0.20 cloned into two 'innodb.log_encrypt_7_mk' and
    'innodb.log_encrypt_7_rk'.
    
    ***
    Similarly to other 'innodb.table_encrypt_<n>' MTR test cases 'innodb.table_encrypt_6'
    coming from upstream 8.0.20 cloned into three 'innodb.table_encrypt_6',
    'keyring_vault.table_encrypt_6' and 'keyring_vault.table_encrypt_6_directory'.
    
    ***
    VERSION raised to "8.0.20-11".
    univ.i version raised to "11".
    percona-ysorokin committed May 29, 2020
    Configuration menu
    Copy the full SHA
    db4895c View commit details
    Browse the repository at this point in the history
  2. PS-6789 (Merge MySQL 8.0.20): Fixed InnoDB monitor MTR test cases

    https://jira.percona.com/browse/PS-6789
    
    In the fix for Bug #30508721
    "MTR DOESN'T KEEP TRACK OF THE STATE OF INNODB MONITORS"
    (commit mysql/mysql-server@abd33c2)
    Oracle extended MTR 'check-testcase' procedure with additional comparison of
    data from InnoDB metrics state. They also introduced
    'mysql-test/include/innodb_monitor_restore.inc' MTR include file that is
    supposed to reset InnoDB monitors to their default state.
    
    'mysql-test/include/innodb_monitor_restore.inc' extended with enabling
    Percona-specific monitors, those that are enabled (defined with
    'MONITOR_DEFAULT_ON' flag) by default.
    
    Similarly to what was done in the upstream patch
      "SET GLOBAL innodb_monitor_enable=default;"
      "SET GLOBAL innodb_monitor_disable=default;"
      "SET GLOBAL innodb_monitor_reset_all=default;"
    statement sequences were substituted with
    '--source include/innodb_monitor_restore.inc' all over the test code.
    
    As the result, fixed the following MTR test cases:
    - 'innodb.innodb_idle_flush_pct'
    - 'innodb.lock_contention_big'
    - 'innodb.monitor'
    - 'innodb.percona_ahi_partitions'
    - 'innodb.percona_changed_page_bmp_flush_5446'
    - 'innodb.transportable_tbsp-debug'
    - 'innodb_zip.transportable_tbsp_debug_zip'
    - 'sys_vars.innodb_monitor_disable_basic'
    - 'sys_vars.innodb_monitor_enable_basic'
    - 'sys_vars.innodb_monitor_reset_all_basic'
    - 'sys_vars.innodb_monitor_reset_basic'
    - 'sys_vars.innodb_purge_run_now_basic'
    - 'sys_vars.innodb_purge_stop_now_basic'
    percona-ysorokin committed May 29, 2020
    Configuration menu
    Copy the full SHA
    ca8423b View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. PS-6789 (Merge MySQL 8.0.20): Re-recorded HASH JOINs and filesort-rel…

    …ated MTR test cases
    
    https://jira.percona.com/browse/PS-6789
    
    The following MTR test cases re-recorded because of the 'filesort' improvements
    introduced in the fix for Oracle's Bug #30776132
    "MAKE FILESORT KEYS CONSISTENT BETWEEN FIELDS AND ITEMS"
    (commit mysql/mysql-server@6d587a6)
    - 'main.pool_of_threads'
    - 'main.pool_of_threads_high_prio_tickets'.
    
    The following MTR test cases re-recorded because of the changed execution plan
    (more hash joins instead of nested blok loops) introduced in these improvements
    Bug #30528604
    "DELETE THE PRE-ITERATOR EXECUTOR"
    (commit mysql/mysql-server@ef166f8),
    Bug #30473261
    "CONVERT THE INDEX SUBQUERY ENGINES INTO USING THE ITERATOR EXECUTOR"
    (commit mysql/mysql-server@cb4116e)
    (commit mysql/mysql-server@629b549)
    (commit mysql/mysql-server@5a41fba)
    (commit mysql/mysql-server@31bd903)
    (commit mysql/mysql-server@75bbe1b)
    (commit mysql/mysql-server@6226c1a)
    (commit mysql/mysql-server@0b45e96)
    (commit mysql/mysql-server@8e45d7e)
    (commit mysql/mysql-server@7493ae4)
    (commit mysql/mysql-server@a5f60bf)
    (commit mysql/mysql-server@609b86e),
    Bug #30912972
    "ASSERTION `KEYLEN == M_START_KEY.LENGTH' FAILED"
    (commit mysql/mysql-server@b28bea5)
    - 'audit_log.audit_log_filter_db'
    - 'main.pool_of_threads'
    - 'main.pool_of_threads_high_prio_tickets'
    - 'main.percona_expand_fast_index_creation'
    - 'main.percona_sequence_table'
    percona-ysorokin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    8a60c3f View commit details
    Browse the repository at this point in the history
  2. PS-6789 (Merge MySQL 8.0.20): Re-recorded main.bug74778 MTR test case

    https://jira.percona.com/browse/PS-6789
    
    Re-recorded 'main.bug74778' MTR test case because of the new 'SHOW_ROUTINE'
    privilege implemented by Oracle in WL #9049
    "Add a dynamic privilege for stored routine backup"
    (https://dev.mysql.com/worklog/task/?id=9049)
    (commit mysql/mysql-server@3e41e44)
    percona-ysorokin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    f91893d View commit details
    Browse the repository at this point in the history
  3. PS-6789 (Merge MySQL 8.0.20): Re-recorded main.backup_locks_mysqldump…

    … MTR test case
    
    https://jira.percona.com/browse/PS-6789
    
    Re-recorded 'main.backup_locks_mysqldump' MTR test case because of the new default
    'mysqldump' network timeout introduced in the fix for Oracle Bug #30755992 / #98203
    "mysql dump sufficiently long network timeout too short"
    (https://bugs.mysql.com/bug.php?id=98203)
    (commit mysql/mysql-server@1f90fad)
    percona-ysorokin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    31a92ff View commit details
    Browse the repository at this point in the history
  4. PS-6789 (Merge MySQL 8.0.20): Re-recorded main.bug88797 MTR test case

    https://jira.percona.com/browse/PS-6789
    
    Re-recorded 'main.bug88797' MTR test case because of the new deprecation
    warning introduced in the implementation of WL #13325
    "Deprecate VALUES syntax in INSERT ... ON DUPLICATE KEY UPDATE"
    (https://dev.mysql.com/worklog/task/?id=13325)
    (commit mysql/mysql-server@6f3b9df)
    percona-ysorokin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c0138f0 View commit details
    Browse the repository at this point in the history
  5. PS-6789 : Merge MySQL 8.0.20

    - Changed use of (Field*)::real_maybe_null to (Field*)::is_nullable due to
      changes in upstream at c5f8a62
    - Added macro trickery to undefine and redefine ZSTD macro required for rocksdb
      around including sql/sql_class.h in order to prevent collision with new
      binlog compression type ZSTD.
    - chmod +x to mysql-test/mysql-test-run.pl
    - Re-recorded test(s) due to binog offet changes:
      - rocksdb.read_only_tx
    - Re-recorded test(s) due to new EXPLAIN result:
      - rocksdb.type_enum_indexes
    - Re-recorded test(s) due to new "hash join" EXPLAIN result:
      - rocksdb.index_merge_rocksdb2
    - Re-recorded test(s) due to new deprecation warning
      "Warning  1287  'VALUES function' is deprecated ...":
      - rocksdb.rocksdb
      - rocksdb.insert_with_keys
    - Re-recorded test(s) due to new column 'Require_table_primary_key_check'
      appearing in 'SHOW CREATE TABLE mysql.slave_relay_log_info;':
      - rocksdb_rppl.rpl_rocksdb_stm_mixed_crash_safe
      - rocksdb_rpl.rpl_rocksdb_row_crash_safe
    - Re-recorded test(s) due to changes to common test in 'extra/rpl_tests':
      - rocksdb_rpl.rpl_rocksdb_stm_mixed_crash_safe
      - rocksdb_rpl.rpl_rocksdb_row_crash_safe
    George O. Lorch III committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    50af841 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. PS-6789 : Merge MySQL 8.0.20

    - Fixed linking issue with PerconaFT by adding new minchassis dependency to
      tokudbdump and advancing git submodule commmit pointer.
    - Changed use of (Field*)::real_maybe_null to (Field*)::is_nullable due to
      changes in upstream at c5f8a62
    - Re-recorded test(s) due to new hash join in explain result:
      - tokudb.type.bit
      - tokudb.type_time
      - tokudb.cluster_2968-0
      - tokudb.cluster_2968-1
      - tokudb.cluster_2968-2
      - tokudb.cluster_2968-3
    - Re-recorded test(s) due to new deprecation warning
      "Warning  1287  '@@max_length_for_sort_data' is deprecated ...":
      - tokudb.type_bit
      - tokudb.type_bit_innnodb
    - Re-recorded test(s) due to new deprecation warning
      "Warning  1287  'VALUES function' is deprecated ...":
      - tokudb.fast_upsert_values
    - Re-recorded test(s) with either ORDER BY or --sorted_result due to
      non-deterministic query order results:
      - tokudb.type_bit
      - tokudb.type_year
    - Re-recorded test(s) due to new behavior of debug function WEIGHT_STRING:
      - tokudb.type_temporal_fractional
    - Re-recorded test(s) due to new column 'Require_table_primary_key_check'
      appearing in 'SHOW CREATE TABLE mysql.slave_relay_log_info;':
      - tokudb_rpl.rpl_tokudb_row_crash_safe
      - tokudb_rpl.rpl_tokudb_stm_mixed_crash_safe
    - Re-recorded test(s) due to changes to common test in 'extra/rpl_tests':
      - tokudb_rpl.rpl_tokudb_row_crash_safe
      - tokudb_rpl.rpl_tokudb_stm_mixed_crash_safe
    - Re-recorded test(s) due to change in SHOW CREATE TABLE that no longer shows
      INT display width:
      - tokudb_parts.partition_max_parts_hash_tokudb
      - tokudb_parts.partition_max_parts_key_tokudb
    - Re-recorded test(s) due to error code changes:
      - tokudb_backup.tokudb_backup_exclude
    George O. Lorch III committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    1ad3e95 View commit details
    Browse the repository at this point in the history