New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy a multi-arch docker image #474
feat: deploy a multi-arch docker image #474
Conversation
cc7585b
to
fecd6ba
Compare
fecd6ba
to
17ec5f9
Compare
- "docker.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8" | ||
- "docker.io/percona/mongodb_exporter:{{.Version}}-arm64v8" | ||
- "ghcr.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8" | ||
- "ghcr.io/percona/mongodb_exporter:{{.Version}}-arm64v8" | ||
dockerfile: Dockerfile | ||
use: buildx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We build this image only for the community and I think it's okey to use buildx :)
dockerfile: Dockerfile | ||
use: buildx | ||
build_flag_templates: | ||
- "--pull" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what does it here, but probably it pulls the latest version of the image to not use the one in a cache. So I think it's ok.
@nikita-b your thoughts
Just added another commit, I realised QEMU + buildx weren't setup in the pipeline |
hm, I though they both inside of goreleaser container |
It might do for binaries, but containers have to be built on the host docker daemon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- "docker.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8" | ||
- "docker.io/percona/mongodb_exporter:{{.Version}}-arm64v8" | ||
- "ghcr.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8" | ||
- "ghcr.io/percona/mongodb_exporter:{{.Version}}-arm64v8" | ||
dockerfile: Dockerfile | ||
use: buildx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We build this image only for the community and I think it's okey to use buildx :)
This PR adds a multi-arch image deployment to the GoReleaser config so the exporter can be used with cloud ARM64 instances such as AWS Graviton.
Once all checks pass and the code is ready for review, please add
pmm-review-exporters
team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.