Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy a multi-arch docker image #474

Merged
merged 7 commits into from May 12, 2022

Conversation

charlie-haley
Copy link
Contributor

This PR adds a multi-arch image deployment to the GoReleaser config so the exporter can be used with cloud ARM64 instances such as AWS Graviton.


  • Tests passed.
  • Fix conflicts with target branch.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.

@it-percona-cla
Copy link

it-percona-cla commented Apr 19, 2022

CLA assistant check
All committers have signed the CLA.

.goreleaser.yml Outdated Show resolved Hide resolved
- "docker.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8"
- "docker.io/percona/mongodb_exporter:{{.Version}}-arm64v8"
- "ghcr.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8"
- "ghcr.io/percona/mongodb_exporter:{{.Version}}-arm64v8"
dockerfile: Dockerfile
use: buildx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikita-b / @BupycHuk Do we need to use buildx for our Docker builds?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We build this image only for the community and I think it's okey to use buildx :)

dockerfile: Dockerfile
use: buildx
build_flag_templates:
- "--pull"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikita-b / @BupycHuk Do we need pull?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what does it here, but probably it pulls the latest version of the image to not use the one in a cache. So I think it's ok.
@nikita-b your thoughts

@charlie-haley
Copy link
Contributor Author

Just added another commit, I realised QEMU + buildx weren't setup in the pipeline

@denisok
Copy link
Contributor

denisok commented May 6, 2022

Just added another commit, I realised QEMU + buildx weren't setup in the pipeline

hm, I though they both inside of goreleaser container

@charlie-haley
Copy link
Contributor Author

Just added another commit, I realised QEMU + buildx weren't setup in the pipeline

hm, I though they both inside of goreleaser container

It might do for binaries, but containers have to be built on the host docker daemon

Copy link

@nikita-b nikita-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- "docker.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8"
- "docker.io/percona/mongodb_exporter:{{.Version}}-arm64v8"
- "ghcr.io/percona/mongodb_exporter:{{.Major}}.{{.Minor}}-arm64v8"
- "ghcr.io/percona/mongodb_exporter:{{.Version}}-arm64v8"
dockerfile: Dockerfile
use: buildx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We build this image only for the community and I think it's okey to use buildx :)

@ShashankSinha252 ShashankSinha252 merged commit 713d50b into percona:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants