Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved go linter workflow out of go.yml #702

Merged
merged 4 commits into from Aug 24, 2023
Merged

moved go linter workflow out of go.yml #702

merged 4 commits into from Aug 24, 2023

Conversation

anishrajan25
Copy link
Contributor

@anishrajan25 anishrajan25 commented Aug 18, 2023 •
edited by ademidoff

Description

Related to issue #701, closes #701

  • Moved linters from go.yml yo separate workflow job.
  • lint checks will still be executed on the same actions/events as before.
image

PMM-XXXX (optional, if ticket reported)

  • Links to other linked pull requests (optional).
  • Tests passed.
  • Fix conflicts with target branch.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@anishrajan25 anishrajan25 requested a review from a team as a code owner August 18, 2023 11:09
@anishrajan25 anishrajan25 requested review from ademidoff and JiriCtvrtka and removed request for a team August 18, 2023 11:09
@it-percona-cla
Copy link

it-percona-cla commented Aug 18, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@anishrajan25 anishrajan25 mentioned this pull request Aug 18, 2023
Closed
@ademidoff
Copy link
Member

ademidoff commented Aug 21, 2023 •
edited

@anishrajan25 Thanks for your contribution! Could you please sign the CLA? You can follow this link to do that.

@ademidoff
Copy link
Member

ademidoff commented Aug 21, 2023 •
edited

I believe it makes sense to move this step as well to this workflow - https://github.com/percona/mongodb_exporter/pull/702/files#diff-678682767f2477de3e3c546746f8568b9a1942b2c647d32331d7e774b8ff8d9fL44-L47.

BupycHuk
BupycHuk reviewed Aug 21, 2023
View reviewed changes
.github/workflows/lint.yml Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Show resolved Hide resolved
@anishrajan25
Copy link
Contributor Author

@BupycHuk @atymchuk Thank you for the initial review and inputs. I have updated the PR with the requested changes. Could you please have a look now?

@JiriCtvrtka JiriCtvrtka mentioned this pull request Aug 22, 2023
Merged
2 tasks
@ademidoff
Copy link
Member

@anishrajan25 It looks good, except that, as @BupycHuk mentioned, we want to move these steps out of go.yml to prevent from executing them repeatedly as part of the matrix test runs.

@anishrajan25
Copy link
Contributor Author

Sorry, it was missed in the last commit. Have updated the PR. Please have a look @atymchuk

@ademidoff ademidoff enabled auto-merge (squash) August 24, 2023 12:47
@ademidoff ademidoff merged commit 4aca88d into percona:main Aug 24, 2023
8 checks passed
@BupycHuk
Copy link
Member

Thanks @anishrajan25 for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ademidoff ademidoff ademidoff approved these changes

@BupycHuk BupycHuk BupycHuk approved these changes

@JiriCtvrtka JiriCtvrtka Awaiting requested review from JiriCtvrtka JiriCtvrtka is a code owner automatically assigned from percona/pmm-review-exporters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate linters from go.yml to another job.
4 participants
@anishrajan25 @it-percona-cla @ademidoff @BupycHuk