Fix bug 1233431 ([ERROR] Cannot find index <col> in InnoDB index tran… #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slation table ...) The issue is that temporary tables also are subject to expand_fast_index_creation, which results in InnoDB index translation table being obsoleted during the secondary key delete/re-add. As a later access to the modified temp table skips ha_innobase::open (which would happen for a regular not temp table), the translation table rebuild is skipped as well, resulting in the warning and error of the bug report. Backport the fix from 5.7: make ha_innobase::final_add_index call innobase_build_index_translation, which is exported from ha_innodb.cc for this purpose. Backport the innodb.percona_expand_fast_index_creation_innodb testcase from 5.7 and add a testcase for bug 1529555 too (which does not fail on 5.5).
|
Changes look good to me. OK to Push. |
laurynas-biveinis
added a commit
that referenced
this pull request
Jan 19, 2016
Fix bug 1233431 ([ERROR] Cannot find index <col> in InnoDB index tran…
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 5, 2016
Summary: In MyRocks, transactions may get "deadlock" errors on snapshot conflicts, when using repeatable read isolation level. This diff adds a status counter to track how many times the errors are returned. Test Plan: mtr Reviewers: jkedgar, spetrunia, santoshb, hermanlee4 Reviewed By: hermanlee4 Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D61761
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 5, 2016
Summary: In MyRocks, transactions may get "deadlock" errors on snapshot conflicts, when using repeatable read isolation level. This diff adds a status counter to track how many times the errors are returned. Test Plan: mtr Reviewers: jkedgar, spetrunia, santoshb, hermanlee4 Reviewed By: hermanlee4 Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D61761
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: In MyRocks, transactions may get "deadlock" errors on snapshot conflicts, when using repeatable read isolation level. This diff adds a status counter to track how many times the errors are returned. Differential Revision: https://reviews.facebook.net/D61761 fbshipit-source-id: 09a250bf446
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: In MyRocks, transactions may get "deadlock" errors on snapshot conflicts, when using repeatable read isolation level. This diff adds a status counter to track how many times the errors are returned. Differential Revision: https://reviews.facebook.net/D61761 fbshipit-source-id: 09a250bf446
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
Summary: In MyRocks, transactions may get "deadlock" errors on snapshot conflicts, when using repeatable read isolation level. This diff adds a status counter to track how many times the errors are returned. Differential Revision: https://reviews.facebook.net/D61761 fbshipit-source-id: b744dd65da7
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: In MyRocks, transactions may get "deadlock" errors on snapshot conflicts, when using repeatable read isolation level. This diff adds a status counter to track how many times the errors are returned. Differential Revision: https://reviews.facebook.net/D61761
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: In MyRocks, transactions may get "deadlock" errors on snapshot conflicts, when using repeatable read isolation level. This diff adds a status counter to track how many times the errors are returned. Differential Revision: https://reviews.facebook.net/D61761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…slation table ...)
The issue is that temporary tables also are subject to
expand_fast_index_creation, which results in InnoDB index translation
table being obsoleted during the secondary key delete/re-add. As a later
access to the modified temp table skips ha_innobase::open (which would
happen for a regular not temp table), the translation table rebuild is
skipped as well, resulting in the warning and error of the bug report.
Backport the fix from 5.7: make ha_innobase::final_add_index call
innobase_build_index_translation, which is exported from ha_innodb.cc
for this purpose.
Backport the innodb.percona_expand_fast_index_creation_innodb testcase
from 5.7 and add a testcase for bug 1529555 too (which does not fail
on 5.5).