Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB-928 : 5.7 support_xa needs to be deprecated as it can break replic… #320

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

george-lorch
Copy link
Contributor

…ation.

  • Modified tokudb_support_xa to prevent setting it to anything but on/enabled and print sql warning anytime an attempt is made to change it, just like innodb_support_xa.
  • Removed extraneous TOKU_INCLUDE_XA as yes, we will always support XA in 5.7 branch forward.
  • Re-recorded tokudb.tokudb_support_xa test to have new warenings and behaviors in the result.

…ation.

* Modified tokudb_support_xa to prevent setting it to anything but on/enabled and print sql warning anytime an attempt is made to change it, just like innodb_support_xa.
* Removed extraneous TOKU_INCLUDE_XA as yes, we will always support XA in 5.7 branch forward.
* Re-recorded tokudb.tokudb_support_xa test to have new warenings and behaviors in the result.
@laurynas-biveinis
Copy link
Contributor

LGTM

george-lorch pushed a commit that referenced this pull request Jan 19, 2016
DB-928 : 5.7 support_xa needs to be deprecated as it can break replic…
@george-lorch george-lorch merged commit a9b32b6 into percona:5.7 Jan 19, 2016
@george-lorch george-lorch deleted the DB-928 branch January 19, 2016 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants