Fix lp:1578303 "rpl.rpl_start_stop_slave fail sporadically on 5.5" (5.6). #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem seems to be in --let $connection_id=`SELECT id FROM information_schema.processlist where state LIKE 'Waiting for master to send event'` At this point slave connection may still be in 'Queueing master event to the relay log' state and therefore $connection_id can be empty. To fix, we need to make sure that there is at least 1 connection with status 'Waiting for master to send event' before reading its id. "wait_condition.inc" can be used for this purpose.
Null merge as "rpl_start_stop_slave.test" no longer exists in 5.6.
|
No Jenkins build link as this is a null merge. |
|
LGTM (null merge) |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: RocksDB has replaced allow_os_buffer with use_direct_reads and use_direct_writes. update-submodule: rocksdb Closes facebook/mysql-5.6#487 Reviewed By: gunnarku Differential Revision: D4370953 Pulled By: lth fbshipit-source-id: ab84ff8 fbshipit-source-id: 386ba040b9e
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: RocksDB has replaced allow_os_buffer with use_direct_reads and use_direct_writes. update-submodule: rocksdb Closes facebook/mysql-5.6#487 Reviewed By: gunnarku Differential Revision: D4370953 Pulled By: lth fbshipit-source-id: ab84ff8 fbshipit-source-id: 386ba040b9e
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
…cona#487) Summary: RocksDB has replaced allow_os_buffer with use_direct_reads and use_direct_writes. update-submodule: rocksdb Closes facebook/mysql-5.6#487 Reviewed By: gunnarku Differential Revision: D4370953 (facebook/mysql-5.6@d85302b) Pulled By: lth fbshipit-source-id: 2ec8fa464de
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…cona#487) Summary: RocksDB has replaced allow_os_buffer with use_direct_reads and use_direct_writes. @update-submodule: rocksdb Closes facebook/mysql-5.6#487 Reviewed By: gunnarku Differential Revision: D4370953 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…cona#487) Summary: RocksDB has replaced allow_os_buffer with use_direct_reads and use_direct_writes. @update-submodule: rocksdb Closes facebook/mysql-5.6#487 Reviewed By: gunnarku Differential Revision: D4370953 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.