Bug1617998 5.7 #940
Merged
Bug1617998 5.7 #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition between HS worker threads initializing default SE and default temp SE fields and the server main thread initializing the same globally w/o locking. As HS workers do not care about the default (temp) SE, initialise their THD handles without plugin support.
satya-bodapati
pushed a commit
to satya-bodapati/percona-server
that referenced
this pull request
Feb 22, 2019
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: fafc6a8c18f
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1e7b7
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1e7b7
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 (facebook/mysql-5.6@e045188) Pulled By: lth fbshipit-source-id: 119d4674eca
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 18, 2022
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Apr 12, 2022
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 15, 2024
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.