FB8-93: output symbolic errno for 'SHOW SLAVE STATUS' #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR was updated with requested changes |
inikep
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
requested changes
Feb 2, 2019
There was a problem hiding this comment.
main.rpl_multi_source_mysqldump_slave looks to fail with different output. The channel name seems to be gone.
CURRENT_TEST: main.rpl_multi_source_mysqldump_slave
--- /mnt/btrfs/trunk-git-mysql-1709-1549047725/mysql-test/r/rpl_multi_source_mysqldump_slave.result 2019-02-01 22:04:25.075739604 +0300
+++ /mnt/btrfs/trunk-git-mysql-1709-1549047725/_build-8.0-Debug/mysql-test/var/15/log/rpl_multi_source_mysqldump_slave.reject 2019-02-01 22:59:11.840036958 +0300
@@ -8,8 +8,8 @@
CHANGE MASTER TO MASTER_HOST='127.0.0.1', MASTER_LOG_FILE='binlog-ch1.000001', MASTER_LOG_POS=4 FOR CHANNEL 'ch1';
CHANGE MASTER TO MASTER_HOST='127.0.0.1', MASTER_LOG_FILE='binlog-ch2.000001', MASTER_LOG_POS=4 FOR CHANNEL 'ch2';
# Execute mysqldump with --dump-slave
-CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch1.000001', MASTER_LOG_POS=4 FOR CHANNEL 'ch1';
-CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch2.000001', MASTER_LOG_POS=4 FOR CHANNEL 'ch2';
+CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch1.000001', MASTER_LOG_POS=0 FOR CHANNEL '';
+CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch2.000001', MASTER_LOG_POS=0 FOR CHANNEL '';
# Execute mysql using the dump as input
include/stop_slave.inc
#
@@ -18,9 +18,9 @@
# Setup the default replication channel
CHANGE MASTER TO MASTER_HOST='127.0.0.1', MASTER_LOG_FILE="binlog-default.000001", MASTER_LOG_POS=4 FOR CHANNEL '';
# Execute mysqldump with --dump-slave
-CHANGE MASTER TO MASTER_LOG_FILE='binlog-default.000001', MASTER_LOG_POS=4 FOR CHANNEL '';
-CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch1.000001', MASTER_LOG_POS=4 FOR CHANNEL 'ch1';
-CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch2.000001', MASTER_LOG_POS=4 FOR CHANNEL 'ch2';
+CHANGE MASTER TO MASTER_LOG_FILE='binlog-default.000001', MASTER_LOG_POS=0 FOR CHANNEL '';
+CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch1.000001', MASTER_LOG_POS=0 FOR CHANNEL '';
+CHANGE MASTER TO MASTER_LOG_FILE='binlog-ch2.000001', MASTER_LOG_POS=0 FOR CHANNEL '';
# Execute mysql using the dump as input
JIRA: https://jira.percona.com/browse/FB8-93 This patch ports the following commits: 1. facebook@a2b0c32 2. facebook@e82ab5a ================================ COMMIT 1 ================================ output symbolic errno for 'SHOW SLAVE STATUS' Summary: Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Differential Revision: D4445585 ================================ COMMIT 2 ================================ fix test failures Summary: squash with D4445585 Differential Revision: D4475433
|
@inikep has updated the pull request. Re-import the pull request |
|
The reason of the failure was a side-effect of this PR in |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
approved these changes
Feb 6, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 11, 2019
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: a2b0c32 Reference Patch: e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: #940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: fafc6a8
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: a2b0c32 Reference Patch: e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: #940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 20, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lth Differential Revision: D13924591 Pulled By: lth fbshipit-source-id: 84765f1
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 15, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 15, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 11, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 12, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 18, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 26, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 15, 2024
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…ercona#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook/mysql-5.6@a2b0c32 Reference Patch: facebook/mysql-5.6@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook/mysql-5.6#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…acebook#940) Summary: JIRA: https://jira.percona.com/browse/FB8-93 Reference Patch: facebook@a2b0c32 Reference Patch: facebook@e82ab5a Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding Pull Request resolved: facebook#940 Reviewed By: lloyd Differential Revision: D13924591 Pulled By: lth --------------------------------------------------------------------------------------------- SHOW SLAVE STATUS shows real error Summary: In parallel replication SHOW SLAVE STATUS doesn't show the actual error. It actually creates the real error (Slave_reporting_capability::va_report) and set m_last_error right after setting coordinator error so we just need to reverse the order of the two and show the real error in coordinator. Accessing the last error is protected by err_lock and also fallback to previous message in case the error number is 0 and can't be trusted, just in case. Reviewed By: hermanlee, Pushapgl Differential Revision: D28925760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.percona.com/browse/FB8-93
Reference Patch: a2b0c32
Reference Patch: e82ab5a
Summary: Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding