PXB-1627: Support obtaining binary log coordinates from performance_s… #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chema.log_status
Implementation details:
At the beginning of the backup PXB detecting is there any MyISAM
tables to backup and whether the server is a GTID slave with auto
positioning.
Privileges needed to query `p_s.log_status` table are checked if
privilege check was requested.
Log copying thread has changed to stop at specific LSN. Log recovery
modified to take a final LSN to recover up to.
`--binlog-info` option has been removed, binary log info always
stored during the backup. Code related to LOCK BACKUP FOR BINLOG
removed because this feature won't be ported to PS 8.
Final stage of the backup now looks like following:
1. Issue FTWRL is needed. Conditions for FTWRL are:
- MyISAM tables
- `-slave-info` is specified and server is not a GTID slave with
auto positioning
2. Copy MyISAM tables
3. Query `p_s.log_status`, save LSN and binary log position
4. Query SHOW SLAVE STATUS if `-slave-info` is specified
5. Stop log copying thread at the LSN obtained from `log_status`
6. Unlock tables if they were locked at step 1
Tests changed:
`binlog_info.sh`: test that binlog info is always created during the
backup stage
`bug1277403.sh`: create MyISAM table to force FTWRL
`bug1343722.sh`: produce the workload on the server we backing up
`bug1630841.sh`: privileges adjusted
`ib_slave_info.sh`: check whether FTWRL was used
`kill_long_selects.sh`: create MyISAM table to force FTWRL
`pxb-1569.sh`: privileges adjusted
gl-sergei
force-pushed
the
8.0-xb-1627
branch
from
bead5ac
to
8c9c37a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…chema.log_status
Implementation details:
At the beginning of the backup PXB detecting is there any MyISAM
tables to backup and whether the server is a GTID slave with auto
positioning.
Privileges needed to query
p_s.log_statustable are checked ifprivilege check was requested.
Log copying thread has changed to stop at specific LSN. Log recovery
modified to take a final LSN to recover up to.
--binlog-infooption has been removed, binary log info alwaysstored during the backup. Code related to LOCK BACKUP FOR BINLOG
removed because this feature won't be ported to PS 8.
Final stage of the backup now looks like following:
-slave-infois specified and server is not a GTID slave withauto positioning
p_s.log_status, save LSN and binary log position-slave-infois specifiedlog_statusTests changed:
binlog_info.sh: test that binlog info is always created during thebackup stage
bug1277403.sh: create MyISAM table to force FTWRLbug1343722.sh: produce the workload on the server we backing upbug1630841.sh: privileges adjustedib_slave_info.sh: check whether FTWRL was usedkill_long_selects.sh: create MyISAM table to force FTWRLpxb-1569.sh: privileges adjusted