Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-8641 PMM v3 API breaking changes #2635

Merged
merged 64 commits into from
Jul 18, 2024
Merged

PMM-8641 PMM v3 API breaking changes #2635

merged 64 commits into from
Jul 18, 2024

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Nov 22, 2023 •
edited by ademidoff
Loading

PMM-8641

Link to the Feature Build: SUBMODULES-3624

ademidoff and others added 3 commits November 22, 2023 14:35
@ademidoff @BupycHuk
PMM-12624 Single inventory service add endpoint (#2591)
d221545 
* PMM-12529 provide one AddService for all types of services

* PMM-12529 use context in transactions

* PMM-12529 remove rpc AddMySQLService

* PMM-12624 remove rpc AddMongoDBService

* PMM-12624 remove rpc AddPostgreSQLService

* PMM-12624 remove rpc AddProxySQLService

* PMM-12624 remove rpc AddHAProxyService

* PMM-12624 remove rpc AddExternalService

* PMM-12624 final cleanup

* PMM-12624 fix the API tests

* PMM-12624 add and update the API docs

* PMM-12624 fix duplicate entry in the sample payload

* PMM-12624 return straight away

* PMM-12624 rename the messages to ...Params

* PMM-12624 reorder the message fields

* Update docs/api/inventory/add-node.md

Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>

---------

Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
@ademidoff
PMM-12681 remove deprecated node add endpoints (#2632)
95043ea 
* PMM-12681 remove deprecated Node/Add... endpoints

* PMM-12681 restore the Makefile

* PMM-12681 trigger CI

* PMM-12681 fix the test

* PMM-12681 rename NodeRequest to NodeParams

* PMM-12681 fix the error messages in tests

* PMM-12529 regen descriptors

* PMM-12529 take descriptors from the parent branch

* PMM-12529 regen descriptors

* PMM-12529 regen descriptors
@artemgavrilov
Merge remote-tracking branch 'origin/v3' into v3-api-breaking-changes
a2c12ca
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 17.20000% with 828 lines in your changes missing coverage. Please review.

Project coverage is 44.48%. Comparing base (8271136) to head (414e603).

Files Patch % Lines
agent/client/client.go 20.28% 55 Missing ⚠️
admin/commands/management/add_mysql.go 0.00% 38 Missing ⚠️
admin/commands/management/add_postgresql.go 0.00% 38 Missing ⚠️
admin/commands/management/add_mongodb.go 0.00% 36 Missing ⚠️
...min/commands/management/add_external_serverless.go 0.00% 31 Missing ⚠️
admin/commands/management/add_proxysql.go 0.00% 26 Missing ⚠️
...ent/agents/postgres/pgstatmonitor/pgstatmonitor.go 0.00% 26 Missing ⚠️
...n/commands/inventory/add_agent_mongodb_exporter.go 0.00% 23 Missing ⚠️
...in/commands/inventory/add_agent_mysqld_exporter.go 0.00% 23 Missing ⚠️
agent/agents/supervisor/supervisor.go 54.90% 23 Missing ⚠️
... and 55 more
Additional details and impacted files 
@@            Coverage Diff             @@
##               v3    #2635      +/-   ##
==========================================
- Coverage   44.55%   44.48%   -0.08%     
==========================================
  Files         367      358       -9     
  Lines       35592    35575      -17     
==========================================
- Hits        15858    15824      -34     
- Misses      18100    18135      +35     
+ Partials     1634     1616      -18
Flag Coverage Δ
admin 11.52% <0.31%> (-0.13%) ⬇️
agent 52.23% <47.09%> (-0.39%) ⬇️
managed 46.78% <ø> (+0.11%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

artemgavrilov and others added 2 commits November 23, 2023 16:05
@artemgavrilov @ademidoff
PMM-12673 Protobuf linters (#2612)
64fcdc3 
* PMM-12673 Replace _INVALID suffix in enums with _UNSPECIFIED

* PMM-12673 Remove unused imports

* Refactor all protobuf enums

* PMM-12673 Fix

* PMM-12673 Fix qan tests

* PMM-12673 Add service suffix to all grpc service names

* PMM-12673 Fix QAN GetReport request/response naming

* PMM-12673 Fix

* PMM-12673 Fix

* PMM-12673 Fix tests

* PMM-12673 Fix tests

* PMM-12673 Fix test

* PMM-12673 Refactor user API requests and responses

* PMM-12673 Fix tests

* PMM-12673 Fix tests

* PMM-12673 Refactor requests/responses names

* PMM-12673 Refactoring

* PMM-12673 Fix

* PMM-12673 Fix

* PMM-12673 Fix

* PMM-12673 Refactoring

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Fix

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Restructure

* PMM-12673 Fix

* PMM-12673 Configure buf lint, setup CI action

* PMM-12673 Cleanup

* PMM-12673 Fix CI

* PMM-12673 Rename

* PMM-12673 Trigger API lint warning

* PMM-12673 Remove redundant go_package option

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Refactoring

* PMM-12673 Fix buf lint in CI

* PMM-12673 Fix

* PMM-12673 add debug data

* PMM-12673 Add debug data [skip ci]

* PMM-12673 Trigger CI

* PMM-12673 Debug

* PMM-12673 Remove debug data

* PMM-12673 Refactoring

* PMM-12673 Fix some linter warnings

* PMM-12673 Fix test

* Update docs/managed/update-process.md

* Update api/buf.yaml

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>

* PMM-12673 Fix API tests

* Fix import allias

* PMM-12673 Post-merge fix

---------

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>
@artemgavrilov
PMM-12646 Exclude inventory API from public spec (#2644)
0e85f91 
* PMM-12646 Exclude inventory API from public API spec

* PMM-12646 Trigger CI
@artemgavrilov
PMM-6722 Preserve empty JSON fields in API responses (#2645)
2ec42aa 
* PMM-6722 enable 'EmitUnpopulated' serialization option

* PMM-6722 Add API test

* PMM-6722 Add license header

* PMM-6722 Fix linter

* PMM-6722 Fix API tests

* PMM-6722 Fix API test

* PMM-6722 Fix API test

* PMM-6722 Fix API tests
@artemgavrilov
Merge remote-tracking branch 'origin/v3' into v3-api-breaking-changes
02edf9c
percona-robot
percona-robot reviewed Dec 18, 2023
View reviewed changes
agent/agentlocal/agent_local_test.go Show resolved Hide resolved
agent/agentlocal/agent_local_test.go Show resolved Hide resolved
agent/client/client_test.go Show resolved Hide resolved
agent/client/client_test.go Show resolved Hide resolved
agent/client/client_test.go Show resolved Hide resolved
agent/client/client_test.go Show resolved Hide resolved
agent/client/client_test.go Show resolved Hide resolved
agent/client/client_test.go Show resolved Hide resolved
percona-robot
percona-robot reviewed Dec 25, 2023
View reviewed changes
managed/services/user/user.go Show resolved Hide resolved
agent/client/deps.go Outdated Show resolved Hide resolved
managed/services/agents/channel/channel.go Outdated Show resolved Hide resolved
api-tests/server/serialization_test.go Outdated Show resolved Hide resolved
percona-robot
percona-robot reviewed Dec 25, 2023
View reviewed changes
agent/client/deps.go Outdated Show resolved Hide resolved
managed/services/agents/channel/channel.go Outdated Show resolved Hide resolved
api-tests/server/serialization_test.go Outdated Show resolved Hide resolved
ademidoff and others added 3 commits December 26, 2023 16:02
@ademidoff
PMM-12624 single inventory agents add endpoint (#2722)
5ee16cf 
* PMM-12624 migrate to a single exporter/add endpoint

* PMM-12624 update descriptors to silence errors

* PMM-12624 upgrade mongo to at least 4.4

* PMM-12624 revert proto fields renumbering

* PMM-12624 rename AddExporter to AddAgent

* PMM-12624 add Agents to refactoring

* PMM-12624 make gen

* PMM-12624 rename addExporter to addAgent

* PMM-12624 add the documentation

* PMM-12624 make grpc methods private
@artemgavrilov
PMM-8019 Support partial updates of settings and other entities (#2705)
32ffd53 
* PMM-8019 Get rid of enable/disable flags in settings

* PMM-8019 Fixes

* PMM-8019 Fix

* PMM-8019 Cleanup

* PMM-8019 Fix tests

* PMM-8019 Fixes

* PMM-8019 Fix migrations order

* PMM-8019 Fix DB migrations

* PMM-8019 Fix tests

* PMM-8019 Update docs

* PMM-8019 Fix

* PMM-8019 Make check enabling toogle optional

* PMM-8019 Make role update params optional

* PMM-8019 Fix API tests

* PMM-8019 Use optional fields for tour flags

* PMM-8019 Use optionals instead of wrappers in API where it's possible

* PMM-8019 Comments

* PMM-8019 Fix tests

* PMM-8019 Fix linters

* PMM-8019 Fix
@artemgavrilov
PMM-12678 Reset protobuf field nums, remove all deprecated stuff from…
a946c50 
… API (#2733)

* PMM-12678 Reorder protobuf fields

* PMM-12678 Fix tests

* PMM-12678 Mark some fileds as reserved

* PMM-12678 Cleanup

* PMM-12678 Fix tests

* PMM-12678 Fix tests

* PMM-12678 Cleanup

* PMM-12678 Cleanup

* PMM-12678 Cleanup

* PMM-12678 Cleanup

* PMM-12678 Fix mocks

* PMM-12678 Fix proto fields numbering
percona-robot
percona-robot reviewed Jan 15, 2024
View reviewed changes
api-tests/server/advisors_test.go Outdated Show resolved Hide resolved
api-tests/server/advisors_test.go Outdated Show resolved Hide resolved
ademidoff and others added 2 commits January 19, 2024 09:32
percona-robot
percona-robot reviewed Jan 25, 2024
View reviewed changes
managed/services/server/server_test.go Outdated Show resolved Hide resolved
managed/services/server/server_test.go Outdated Show resolved Hide resolved
ademidoff and others added 5 commits May 31, 2024 14:12
@ademidoff
Merge branch 'v3' into v3-api-breaking-changes
483ba4d
@ademidoff @BupycHuk
PMM-13020 Drop identifier prefixes (#2970)
5543ab4 
* PMM-13020 Add a db migration

* PMM-13020 strip agent_id, node_id, action_id

* PMM-13020 drop service_id

* PMM-13020 drop machine_id

* PMM-13020 drop location_id

* Update agent/agents/mysql/slowlog/slowlog_test.go

Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>

* PMM-13020 fix wrong strip-offs

* PMM-13020 fix text output spacing

* PMM-13020 fix text output spacing

* PMM-13020 drop role_id migration

* PMM-13020 fix text output spacing

* PMM-13020 fix wrong agent_id

* PMM-13020 fix slowlog jsons

* PMM-13020 fix scrape config and rds tests

* PMM-13020 fix scrape config test

* PMM-13020 fix victoriametrics test

* PMM-13020 fix node_helpers test

* PMM-13020 fix grafana test (name was too long)

* PMM-13020 strip prefixes in qan fixtures

* PMM-13020 fix QAN tests

* PMM-13020 cut the prefix when reading params

* PMM-13020 fix the job_name in vm tests

* PMM-13020 update the docs

---------

Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
@ademidoff
Merge branch 'v3' into v3-api-breaking-changes
108972f
@ademidoff
Merge branch 'v3' into v3-api-breaking-changes
0cd0ea2
@ademidoff
Merge branch 'v3' into v3-api-breaking-changes
b6700b2
percona-robot
percona-robot reviewed Jun 27, 2024
View reviewed changes
managed/services/server/server.go Outdated Show resolved Hide resolved
agent/runner/actions/mongodb_query_admincommand_action.go Outdated Show resolved Hide resolved
managed/services/management/node.go Outdated Show resolved Hide resolved
managed/services/server/server.go Outdated Show resolved Hide resolved
api-tests/server/serialization_test.go Outdated Show resolved Hide resolved
@ademidoff
Merge branch 'v3' into v3-api-breaking-changes
cbeb02c
@ademidoff
PMM-12913 Migrate api endpoints to REST (#2880)
b0ba464 
* PMM-12913 Add a resource name to endpoints ending with /v1

* PMM-12913 fix the linter error (goconst)

* PMM-12913 migrate /v1/version

* PMM-12913 migrate /v1/readyz

* PMM-12913 all endpoints begin with `/v1`

* PMM-12913 make gen

* PMM-12913 migrate /v1/settings/Get

* PMM-12913 fix unit test fo /v1/server/settings

* PMM-12913 migrate /v1/settings/Change

* PMM-12913 migrate /v1/AWSInstanceCheck

* PMM-12913 fix alerting api tests

* PMM-12913 fix ManagementService being disabled

* PMM-12913 fix backup API tests

* PMM-12913 temporarily allow /v1/version

* PMM-12913 update admins' readme

* PMM-12913 fix the Agent connect path in auth

* PMM-12913 fix wrong grpc paths

* PMM-12913 fix the port in readme

* PMM-12913 fix some grpc paths

* PMM-12913 add check-agent-setup script

* PMM-12913 migrate /v1/server/leaderHealthCheck endpoint

* PMM-12913 migrate /v1/settings/Get

* PMM-12913 fix the api test

* PMM-12913 migrate /v1/updates/Start

* PMM-12913 fix actions

* PMM-12913 migrate /logs.zip

* PMM-12913  fix auth_server_test

* PMM-12913 migrate /v1/updates/Status

* PMM-12913 migrate /v1/users

* PMM-12913 migrate /v1/inventory/Agents

* PMM-12913 fix logs_test

* PMM-12913 use an interface for commonAgentParams

* PMM-12913 re-add `/agent_id/`

* PMM-12913 migrate /v1/inventory/Agents/Get

* PMM-12913 migrate /v1/inventory/Agents/Remove

* PMM-12913 migrate /v1/inventory/Agents/GetLogs

* PMM-12913 migrate /v1/inventory/Nodes

* PMM-12913 migrate /v1/inventory/Services

* PMM-12913 fix tests for /v1/inventory/services

* PMM-12913 migrate /v1/management/Service

* PMM-12913 migrate /v1/actions

* PMM-12899 migrate /v1/alerting endpoints

* PMM-12899 migrate /v1/advisors emdpoints

* PMM-12899 rename BackupsService to BackupService

* PMM-12899 migrate /v1/backup/Artifacts

* PMM-12899 migrate /v1/backup/Backups

* PMM-12913 refactor /v1/backups/locations

* PMM-12913 refactor /v1/backups/restores

* PMM-12913 refactor /v1/dumps

* PMM-12913 move dump and role API to v1beta1 folder

* PMM-12913 refactor /v1/role, rename tp /v1/accesscontrol

* PMM-12913 refactor /v1/management/nodes {Get,LIst}

* PMM-12913 refactor /v1/management/services/List

* PMM-12913 refactor /v1/management/services/azure

* PMM-12913 refactor /v1/management/agent/List

* PMM-12913 migrate /v1/platform

* PMM-12913 migrate /v1/qan

* PMM-12913 refactor the primitive types in alerting.proto

* PMM-12913 fix a few linter errors

* PMM-12913 do not show CollectorService in swagger

* PMM-12913 split /backup/GetLogs up to two endpoints

* PMM-12913 fix restore tests

* PMM-12913 update migration examples

* PMM-12913 fix /v1/qan/metrics:getFilters being unavailable

* PMM-12913 fix the linter error

* PMM-12913 fix /v1/qan/metrics:getFilters test

* PMM-12913 update migration examples

* PMM-12913 fix an iteration bug

* PMM-12913 fix an issue with QAN failing to persist data

* PMM-12913 remove debug output

* PMM-12913 auth_server fixes for QAN

* PMM-12913 fix agent API tests

* PMM-12913 fix the QAN URL routing issue

* PMM-12913 remove the unnecessary PMM_NICER_API

* PMM-12913 add the routing error handler

* PMM-12913 minor syntax fixes

* PMM-12913 remove PMM_LESS_LOG_NOISE envvar

* PMM-12913 remove ID normalizers

* PMM-12913 update the migration doc

* PMM-12913 better error handling

* PMM-12913 fix /v1/backups/artifacts/{artifact_id} delete endpoint

* PMM-12913 simplify setup.py

* PMM-12913 fix a linter error

* PMM-12913 merge ArtifactService with BackupService

* Revert "PMM-12913 better error handling"

This reverts commit add2d3f.

* PMM-12913: regenerate code, fix Makefile.include

* PMM-12913: fix node_test

* PMM-12913: fix UnregisterNode method name

* PMM-12857 fix API tests

* PMM-12857 fix agent tests

* PMM-12857 fix auth_test and clean up readyz_test

* PMM-12857 fix settings_test

* PMM-12857 fix auth_test

* PMM-13054 fix the backup test

* PMM-13054 fix advisor tests

* PMM-13054 fix auth_server tests again

* PMM-13054 remove redundant functionality

* PMM-13054 fix actions tests

* PMM-13054 minor cleanup

* PMM-13054 disable platform tests until the env is ready

* PMM-13054 fix advisors_test

* PMM-13054 try better error msg to debug failures

* PMM-13054 fix alerting_test

* Revert "PMM-13054 try better error msg to debug failures"

This reverts commit 862ec3b.
percona-robot
percona-robot reviewed Jul 15, 2024
View reviewed changes
api/inventory/v1/agents.go Show resolved Hide resolved
agent/runner/runner_test.go Show resolved Hide resolved
agent/runner/runner_test.go Show resolved Hide resolved
@ademidoff ademidoff marked this pull request as ready for review July 18, 2024 08:31
@ademidoff ademidoff requested review from ademidoff and removed request for a team July 18, 2024 08:31
@ademidoff ademidoff merged commit ee86153 into v3 Jul 18, 2024
25 of 30 checks passed
@ademidoff ademidoff deleted the v3-api-breaking-changes branch July 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@percona-robot percona-robot percona-robot left review comments

@ademidoff ademidoff ademidoff approved these changes

@BupycHuk BupycHuk BupycHuk approved these changes

@idoqo idoqo Awaiting requested review from idoqo idoqo is a code owner

@JiriCtvrtka JiriCtvrtka Awaiting requested review from JiriCtvrtka JiriCtvrtka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@artemgavrilov @it-percona-cla @ademidoff @BupycHuk @percona-robot @idoqo @catalinaadam