Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13129 Encryption. #3002

Open
wants to merge 183 commits into
base: v3
Choose a base branch
from
Open

PMM-13129 Encryption. #3002

wants to merge 183 commits into from

Conversation

JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented May 23, 2024

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 54.58422% with 213 lines in your changes missing coverage. Please review.

Project coverage is 44.70%. Comparing base (9dcabbd) to head (23d5d33).

Files with missing lines Patch % Lines
managed/models/encryption_helpers.go 50.00% 68 Missing and 12 partials ⚠️
managed/utils/encryption/encryption.go 48.51% 42 Missing and 10 partials ⚠️
managed/utils/encryption/helpers.go 56.98% 33 Missing and 7 partials ⚠️
managed/models/database.go 68.42% 8 Missing and 10 partials ⚠️
managed/services/agents/agents.go 36.36% 5 Missing and 2 partials ⚠️
managed/services/agents/service_info_broker.go 0.00% 6 Missing ⚠️
managed/models/agent_helpers.go 88.46% 0 Missing and 3 partials ⚠️
managed/services/management/postgresql.go 0.00% 3 Missing ⚠️
managed/services/agents/connection_checker.go 0.00% 2 Missing ⚠️
managed/services/management/mongodb.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3002      +/-   ##
==========================================
+ Coverage   44.61%   44.70%   +0.08%     
==========================================
  Files         357      360       +3     
  Lines       35711    36143     +432     
==========================================
+ Hits        15933    16158     +225     
- Misses      18154    18322     +168     
- Partials     1624     1663      +39     
Flag Coverage Δ
admin 11.52% <ø> (ø)
agent 52.81% <ø> (-0.14%) ⬇️
managed 46.83% <54.58%> (+0.15%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/serverpb/server.proto Outdated Show resolved Hide resolved
@JiriCtvrtka JiriCtvrtka enabled auto-merge (squash) September 9, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants