PMM-9242 ARM build for PMM Client v3 #3022
Conversation
build/scripts/build-client-docker
Outdated
| --platform linux/amd64,linux/arm64 \ | ||
| --squash \ | ||
| --no-cache \ | ||
| --push \ |
There was a problem hiding this comment.
Same here - pushing the image takes place on line 39.
There was a problem hiding this comment.
@talhabinrizwan PTAL ^
There was a problem hiding this comment.
docker save isn't really pushing, is it?
There was a problem hiding this comment.
docker save isn't really pushing, is it?
No, it is not, but docker push was somehow removed from that block of code.
There was a problem hiding this comment.
ah, right, you mentioned line 39, that's why I didn't look above
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3022 +/- ##
=======================================
Coverage 44.42% 44.42%
=======================================
Files 368 368
Lines 35556 35556
=======================================
Hits 15794 15794
+ Misses 18139 18137 -2
- Partials 1623 1625 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
force-pushed
the
v3
branch
3 times, most recently
from
8421bc2
to
da25a0c
Compare
PMM-9242
Link to the Feature Build: SUBMODULES-3635
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: