Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13054 Increase the log line count #3034

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Jun 17, 2024

PMM-13054

Link to the Feature Build: SUBMODULES-3651

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

managed/services/supervisord/logs.go Outdated Show resolved Hide resolved
managed/services/supervisord/logs.go Outdated Show resolved Hide resolved
managed/services/supervisord/logs.go Outdated Show resolved Hide resolved
managed/services/supervisord/logs.go Outdated Show resolved Hide resolved
@ademidoff ademidoff force-pushed the PMM-13054-increase-exported-log-line-count branch 2 times, most recently from 748b5cc to e68d0b2 Compare June 20, 2024 12:36
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.37%. Comparing base (794262c) to head (c227e61).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3034      +/-   ##
==========================================
+ Coverage   43.29%   43.37%   +0.07%     
==========================================
  Files         399      399              
  Lines       41604    41592      -12     
==========================================
+ Hits        18012    18040      +28     
+ Misses      21580    21537      -43     
- Partials     2012     2015       +3     
Flag Coverage Δ
admin 11.67% <ø> (+0.05%) ⬆️
agent 52.82% <ø> (+0.37%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff force-pushed the PMM-13054-increase-exported-log-line-count branch 3 times, most recently from 7d471fa to b829498 Compare June 20, 2024 13:38
@ademidoff ademidoff force-pushed the PMM-13054-increase-exported-log-line-count branch from 00511ec to a96231a Compare June 20, 2024 14:32
@ademidoff ademidoff marked this pull request as ready for review June 20, 2024 14:47
@ademidoff ademidoff requested a review from a team as a code owner June 20, 2024 14:47
@ademidoff ademidoff requested review from idoqo and JiriCtvrtka and removed request for a team June 20, 2024 14:47
Co-authored-by: Jiří Čtvrtka <62988319+JiriCtvrtka@users.noreply.github.com>
@ademidoff ademidoff requested a review from a team as a code owner June 21, 2024 10:48
@ademidoff ademidoff requested review from BupycHuk and removed request for a team June 21, 2024 10:48
@ademidoff ademidoff force-pushed the PMM-13054-increase-exported-log-line-count branch 2 times, most recently from 31a2225 to 9267dad Compare June 21, 2024 12:01
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you know why tests are failing?

managed/services/supervisord/logs.go Outdated Show resolved Hide resolved
managed/services/supervisord/logs_test.go Show resolved Hide resolved
managed/services/supervisord/logs_test.go Outdated Show resolved Hide resolved
@ademidoff
Copy link
Member Author

ademidoff commented Jun 24, 2024

LGTM, do you know why tests are failing?

I believe they fail because of our repo, which is unstable, but I may be wrong. Those failures are not permanent.

@ademidoff ademidoff force-pushed the PMM-13054-increase-exported-log-line-count branch 20 times, most recently from c227e61 to a8aa2e8 Compare July 8, 2024 08:08
@ademidoff ademidoff force-pushed the PMM-13054-increase-exported-log-line-count branch 4 times, most recently from 59480cf to c86439c Compare July 8, 2024 08:14
@ademidoff ademidoff force-pushed the PMM-13054-increase-exported-log-line-count branch from 503fc83 to 4ee55c4 Compare July 8, 2024 09:28
@ademidoff ademidoff merged commit 046ff0b into main Jul 8, 2024
7 of 9 checks passed
@ademidoff ademidoff deleted the PMM-13054-increase-exported-log-line-count branch July 8, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants