PMM-13077 list change log for PMM server version #3045
+474
−388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3045 +/- ##
==========================================
+ Coverage 43.35% 44.54% +1.18%
==========================================
Files 400 367 -33
Lines 41631 35590 -6041
==========================================
- Hits 18051 15854 -2197
+ Misses 21563 18100 -3463
+ Partials 2017 1636 -381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idoqo
requested review from
ademidoff and
JiriCtvrtka
and removed request for
a team
This adds support for PMM release notes by fetching the correct markdown files from github. It also includes fixes for api tests by accepting v3 prefixes in versions.
idoqo
force-pushed
the
PMM-13077-list-pmm-server-versions
branch
from
3cd5397
to
6cc2711
Compare
| @@ -421,3 +434,44 @@ func isHostAvailable(host string, port string, timeout time.Duration) bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| // GetReleaseNotesText returns the change log for a specific PMM server release. | |||
| // if the version argument has an extra label (e.g 2.40.0-alpha), it strips the label | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Sentence should start with a capital letter (godot)
idoqo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13077
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: