Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13077 list versions #3033

Closed

Conversation

idoqo
Copy link
Contributor

@idoqo idoqo commented Jun 16, 2024

PMM-0

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

dependabot bot and others added 30 commits April 8, 2024 16:20
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.19.0 to 0.20.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.19.0...v0.20.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2949)

Bumps [github.com/apache/skywalking-eyes](https://github.com/apache/skywalking-eyes) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/apache/skywalking-eyes/releases)
- [Changelog](https://github.com/apache/skywalking-eyes/blob/main/CHANGES.md)
- [Commits](apache/skywalking-eyes@v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/apache/skywalking-eyes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 7.2.0 to 7.6.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.6.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ts (#2953)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.3.1 to 7.6.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.6.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-playwright](https://github.com/playwright-community/eslint-plugin-playwright) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/playwright-community/eslint-plugin-playwright/releases)
- [Changelog](https://github.com/playwright-community/eslint-plugin-playwright/blob/main/CHANGELOG.md)
- [Commits](playwright-community/eslint-plugin-playwright@v1.5.1...v1.6.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-playwright
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/mongodb/mongo-go-driver/releases)
- [Commits](mongodb/mongo-go-driver@v1.14.0...v1.15.0)

---
updated-dependencies:
- dependency-name: go.mongodb.org/mongo-driver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 7.6.0 to 7.7.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.7.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ts (#2957)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.6.0 to 7.7.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.7.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/prometheus/common from 0.47.0 to 0.52.3

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.47.0 to 0.52.3.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.47.0...v0.52.3)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* PMM-7 Update percona/exporter_shared

* PMM-7 Update percona/exporter_shared

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
Co-authored-by: Michael Okoko <10512379+idoqo@users.noreply.github.com>
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.52.3 to 0.53.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.52.3...v0.53.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactored environment variables

* update migration doc

* replace test line

* drop no lint rule

* fix parser tests

* re-order table values

* remove deprecated env variables

* fix tests

* use singluar advisor

* introduce PMM_DEV_ prefix for dev-related variables

* clean up environment variables

* drop printf

* drop unused variable

* update tests

* add notes for removed variable

* update oauth variables

* update changed variable list

* update variable check validation

* refactor tests

* surpress linter error
* PMM-7 upgrade codecov-action

* PMM-7 add codecov token

* PMM-7 add token to update.yml

* PMM-7 trigger the build

* PMM-7 output NodeJS version

* PMM-7 output npx and playwright versions
* PMM-7 Test.

* trigger

* trigger

* trigger

* trigger

* trigger

* trigger

* trigger

* trigger

* trigger

* PMM-7 test.

* trigger

* trigger

* trigger

* PMM-7 Test if fails are due to locked accounts.

* PMM-7 Test not in parallels.

* trigger

* trigger

* trigger

* PMM-7 Comment about locks.

* trigger
…ts (#2980)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.7.0 to 7.8.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.8.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 7.7.0 to 7.8.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.8.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-12741 Use folder uid for alert rules & handle evaluation interval

* PMM-12741 Format files

* PMM-12741 Rename parameter
* PMM-3303 Monitor internal clickhouse

* PMM-3303 Fix linter

* PMM-3303 Fix tests

---------

Co-authored-by: Roman Novikov <roma.novikov@percona.com>
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.20.0 to 0.21.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.20.0...v0.21.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-13095 Remove trimming of slowlog query IDs.

* PMM-13095 Lint.

* PMM-13095 Typo.

* Update agent/agents/mysql/slowlog/slowlog.go

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>

* PMM-13095 Changes.

---------

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>
…ts (#2988)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.8.0 to 7.9.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.9.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-7 fix supervisor install

* PMM-7 pass --trusted-host parameter

* PMM-7 fix the path to pip executable

* PMM-7 add one more trusted python site
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 20 commits May 21, 2024 10:08
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ame time (#2898)

* Add limit for actions/jobs executed on the same DB at the same time

* PMM-12896 Fix

* PMM-12896 Fixes

* PMM-12896 Fix

* PMM-12896 Fix tests

* PMM-12896 Improvements, fixes, comments, tests

* PMM-12896 Make per DB capacity configurable

* PMM-12896 Fix

* PMM-12896 Improve tests

* PMM-12896 Linter fixes

* PMM-12896 Refactoring

* PMM-12896 Fix comment

* PMM-12896 Fix DSN method for PT mysql summary action

* PMM-12896 Fix bug in local semaphores releasing

* PMM-12896 Refactoring

* PMM-12896 Refactoring

* PMM-12896 Refactoring

* PMM-12896 Refactoring

* PMM-12896 Fix test

* PMM-12896 Fix tests

* Revert "PMM-12896 Fix tests"

This reverts commit 477790b.

* PMM-12896 Fix tests

* PMM-12896 Use timeout only for job/action exectuion, not for resources awaiting

* PMM-12896 Refactoring

* Update agent/config/config.go

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>

* Update agent/runner/actions/mongodb_explain_action.go

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>

* Update agent/runner/actions/postgresql_query_select_action.go

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>

* PMM-12896 Refactoring

* PMM-12896 Mute linter

---------

Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>
Co-authored-by: Vasyl Yurkovych <59879559+yurkovychv@users.noreply.github.com>
# Conflicts:
#	build/ansible/roles/supervisord-init/tasks/main.yml
#	build/docker/rpmbuild/Dockerfile
#	managed/services/victoriametrics/prometheus.go
#	managed/services/victoriametrics/scrape_configs.go
#	update/docker-compose.yml
* PMM-12895 Add metrics resolutions configuration to agents

* PMM-12895 Fix linter warnings

* Update api-tests/inventory/agents_test.go

* PMM-12895 Add tests

* PMM-12895 Fix linter

* PMM-12895 Fix linter

* PMM-12895 Fix API tests

* PMM-12895 Revert breaking changes

* Revert "PMM-12895 Fix API tests"

This reverts commit 54dda0b.

* PMM-12895 Don't retrun empty metrics resoutions object
…3003)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 7.10.0 to 7.11.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.11.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.10.0 to 7.11.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.11.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-12880 Proper skip for TLS certs.

* PMM-12880 Lint.

* PMM-12880 Add comment.

* PMM-12880 Another comment.
* PMM-12522 Collect chunks metrics in low resolution.

* PMM-12522 Collect chunks metrics in low resolution.

* PMM-12522 Remove unnecessary line.

* PMM-12522 Fix linter.

* PMM-12522 revert no used linter.
* PMM-12880 Proper skip for TLS certs.

* PMM-12880 Lint.

* PMM-12880 Add comment.

* PMM-12880 Another comment.
* PMM-13137 Fix SHA1 deprecation in EL9

* PMM-12137 bump up go to v1.22.3
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.11.0 to 7.12.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.12.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3011)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 7.11.0 to 7.12.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.12.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-13145 Fix for older clients.

* PMM-13145 Small changes.

* PMM-13145 Lint.

* PMM-13145 Lint.

* PMM-13145 Logic fix.

* PMM-13145 Refactor.

* PMM-13145 Fix after refactor.

* Update managed/models/agent_model.go

Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>

* Update managed/models/agent_model.go

Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>

---------

Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
This adds a new array field to list all the versions between the
currently installed PMM version and the latest released version.

Additionally, it adds support for release notes text by querying the
appropriate github file for the raw markdown document.
@it-percona-cla
Copy link

it-percona-cla commented Jun 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ idoqo
✅ ademidoff
✅ talhabinrizwan
✅ artemgavrilov
✅ JiriCtvrtka
✅ matejkubinec
✅ BupycHuk
❌ PMM Jenkins


PMM Jenkins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 55.06329% with 213 lines in your changes missing coverage. Please review.

Please upload report for BASE (PMM-12762-get-notified-about-new-version@26b57d5). Learn more about missing BASE report.

Files Patch % Lines
agent/runner/jobs/pbm_helpers.go 0.00% 25 Missing ⚠️
agent/runner/runner.go 86.25% 12 Missing and 6 partials ⚠️
agent/client/client.go 6.25% 15 Missing ⚠️
managed/cmd/pmm-managed/main.go 0.00% 11 Missing ⚠️
managed/models/agent_helpers.go 52.38% 5 Missing and 5 partials ⚠️
agent/runner/jobs/mongodb_backup_job.go 20.00% 8 Missing ⚠️
managed/services/agents/connection_checker.go 0.00% 7 Missing ⚠️
managed/services/agents/service_info_broker.go 0.00% 7 Missing ⚠️
managed/services/server/server.go 25.00% 6 Missing ⚠️
agent/runner/actions/mongodb_explain_action.go 50.00% 4 Missing and 1 partial ⚠️
... and 34 more
Additional details and impacted files
@@                             Coverage Diff                             @@
##             PMM-12762-get-notified-about-new-version    #3033   +/-   ##
===========================================================================
  Coverage                                            ?   44.60%           
===========================================================================
  Files                                               ?      368           
  Lines                                               ?    35362           
  Branches                                            ?        0           
===========================================================================
  Hits                                                ?    15772           
  Misses                                              ?    17967           
  Partials                                            ?     1623           
Flag Coverage Δ
admin 11.59% <ø> (?)
agent 52.61% <57.27%> (?)
vmproxy 66.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return nil, &version.DockerVersionInfo{
Version: *parsed,
DockerImage: tag,
ReleaseNotesURL: "https://per.co.na/pmm/" + parsed.String(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
string https://per.co.na/pmm/ has 4 occurrences, make it a constant (goconst)


s.l.Infof("%+v", res.AvailableVersions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
avoid direct access to proto field res.AvailableVersions, use res.GetAvailableVersions() instead (protogetter)

up.l.Infof("Found %d tags", len(tagsResponse.Results))
next := up.next(*up.currentVersion(), tagsResponse.Results)
up.l.Debugf("Found %d tags", len(tagsResponse.Results))
newerVersions, next := up.next(*up.currentVersion(), tagsResponse.Results)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Function next should pass the context parameter (contextcheck)

@@ -287,26 +319,39 @@ func (up *Updater) next(currentVersion version.Parsed, results []result) *versio
if !currentVersion.Less(v) {
continue
}
releaseNote, err := up.getReleaseNotesText(context.Background(), *v)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
ineffectual assignment to err (ineffassign)

}

// next returns both a list of newer versions and the next version that can be upgraded to.
func (up *Updater) next(currentVersion version.Parsed, results []result) (available []*version.DockerVersionInfo, next *version.DockerVersionInfo) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
named return "available" with type "[]*version.DockerVersionInfo" found (nonamedreturns)

@idoqo
Copy link
Contributor Author

idoqo commented Jun 22, 2024

Closed in favour of #3045

@idoqo idoqo closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants