Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAAS-140 Support MongoDB types #599

Merged
merged 10 commits into from
Oct 27, 2020
Merged

SAAS-140 Support MongoDB types #599

merged 10 commits into from
Oct 27, 2020

Conversation

palash25
Copy link
Contributor

@palash25 palash25 commented Oct 19, 2020 •
edited
Loading

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@artemgavrilov @AlekSi
SAAS-377 Disable checks by name (#588)
e7cb1c4 
* SAAS-377 Add API for checks disabling

* SAAS-377 Make checks API consistent with other PMM APIs

* SAAS-377 Eliminate types collision in swagger generated code

* SAAS-377 Renaming

* SAAS-377 Fix typo

* SAAS-377 Renaming

* SAAS-377 Refactoring

* SAAS-377 Renaming

* SAAS-377 Minor tweaks

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
@palash25 palash25 force-pushed the SAAS-140-support-mongodb-timestamp-type branch 2 times, most recently from 7d8e66b to df0a96c Compare October 21, 2020 18:11
@palash25 palash25 marked this pull request as ready for review October 21, 2020 18:31
@BupycHuk
Copy link
Member

@palash25 please use release/2.12 as base branch

@palash25 palash25 force-pushed the SAAS-140-support-mongodb-timestamp-type branch from df0a96c to 1bede92 Compare October 21, 2020 18:34
@palash25 palash25 changed the base branch from PMM-2.0 to release/2.12 October 21, 2020 18:35
@palash25
Copy link
Contributor Author

this is breaking two tests in pmm-agent for some reason

== CONT  TestAgentClosesConnection
=== CONT  TestAgentRequest
--- PASS: TestServerExitsWithGRPCError (0.00s)
    TestAgentClosesConnection: channel_test.go:86: 
                Error Trace:    channel_test.go:86
                                                        channel_test.go:335
                Error:          []error{(*status.Error)(0xc000318098), (*status.Error)(0xc0003180a0)} does not contain &status.Error{e:(*status.Status)(0xc000128a80)}
                Test:           TestAgentClosesConnection
                Messages:       rpc error: code = Unavailable desc = transport is closing
                                failed to receive message
                                github.com/percona/pmm-agent/client/channel.(*Channel).runReceiver
                                        /home/palash25/dev/go/src/github.com/percona/pmm-agent/client/channel/channel.go:199
                                runtime.goexit
                                        /usr/local/go/src/runtime/asm_amd64.s:1373
    TestServerExitsWithUnknownError: channel_test.go:86: 
                Error Trace:    channel_test.go:86
                                                        channel_test.go:280
                Error:          []error{(*status.Error)(0xc000318080)} does not contain &status.Error{e:(*status.Status)(0xc0000470e0)}
                Test:           TestServerExitsWithUnknownError
                Messages:       rpc error: code = Unknown desc = EOF
                                failed to receive message
                                github.com/percona/pmm-agent/client/channel.(*Channel).runReceiver
                                        /home/palash25/dev/go/src/github.com/percona/pmm-agent/client/channel/channel.go:199
                                runtime.goexit
                                        /usr/local/go/src/runtime/asm_amd64.s:1373
--- PASS: TestUnexpectedResponseFromServer (0.00s)
--- PASS: TestAgentClosesStream (0.00s)
--- FAIL: TestServerExitsWithUnknownError (0.01s)
--- PASS: TestServerRequest (0.01s)
    TestAgentRequestWithTruncatedInvalidUTF8: channel_test.go:86: 
                Error Trace:    channel_test.go:86
                                                        channel_test.go:140
                Error:          []error{(*status.Error)(0xc000318048)} does not contain &status.Error{e:(*status.Status)(0xc0005a8480)}
                Test:           TestAgentRequestWithTruncatedInvalidUTF8
                Messages:       rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
                                failed to send message
                                github.com/percona/pmm-agent/client/channel.(*Channel).send
                                        /home/palash25/dev/go/src/github.com/percona/pmm-agent/client/channel/channel.go:183
                                github.com/percona/pmm-agent/client/channel.(*Channel).SendRequest
                                        /home/palash25/dev/go/src/github.com/percona/pmm-agent/client/channel/channel.go:156
                                github.com/percona/pmm-agent/client/channel.TestAgentRequestWithTruncatedInvalidUTF8
                                        /home/palash25/dev/go/src/github.com/percona/pmm-agent/client/channel/channel_test.go:138
                                testing.tRunner
                                        /usr/local/go/src/testing/testing.go:991
                                runtime.goexit
                                        /usr/local/go/src/runtime/asm_amd64.s:1373
--- FAIL: TestAgentRequestWithTruncatedInvalidUTF8 (0.01s)
--- PASS: TestAgentRequest (0.01s)
^CFAIL  github.com/percona/pmm-agent/client/channel     6.665s
FAIL

@palash25 palash25 force-pushed the SAAS-140-support-mongodb-timestamp-type branch from 06972d2 to a8239ff Compare October 22, 2020 08:54
AlekSi
AlekSi suggested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MarshalActionQuerySQLResult and MarshalActionQueryDocsResult should convert primitive.Timestamp to tspb.Timestamp just like time.Time.

There should not be a separate field or type for MongoDB timestamps

Base automatically changed from release/2.12 to PMM-2.0 October 27, 2020 10:26
@AlekSi AlekSi self-assigned this Oct 27, 2020
@AlekSi
Copy link
Contributor

AlekSi commented Oct 27, 2020

@BupycHuk @artemgavrilov PTAL

@AlekSi AlekSi changed the title SAAS-140 Support mongodb timestamp SAAS-140 Support MongoDB types Oct 27, 2020
@AlekSi AlekSi merged commit bedfd7a into PMM-2.0 Oct 27, 2020
@AlekSi AlekSi deleted the SAAS-140-support-mongodb-timestamp-type branch October 27, 2020 17:54
artemgavrilov pushed a commit that referenced this pull request Jun 17, 2022
@palash25 @AlekSi
PMM-7220 Don't delete template if it is being used by rules (#599)
11ffdc5 
* PMM-7220 Don't delete template if it is being used by rules

* PMM-7220 add FindRuleByTemplateName helper

* PMM-7220 remove helper

* PMM-7220 don't ignore error

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@artemgavrilov artemgavrilov artemgavrilov approved these changes

@BupycHuk BupycHuk Awaiting requested review from BupycHuk

Assignees

@AlekSi AlekSi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@palash25 @CLAassistant @BupycHuk @AlekSi @artemgavrilov @yareach