SAAS-107 Add comments #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
approved these changes
Sep 14, 2020
JiriCtvrtka
approved these changes
Sep 14, 2020
askomorokhov
approved these changes
Sep 14, 2020
BupycHuk
pushed a commit
that referenced
this pull request
Oct 27, 2020
AlekSi
added a commit
that referenced
this pull request
Oct 27, 2020
* Added go 1.15.x. (#592) Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * SAAS-107 Add comments (#581) * PMM-6759 Support GET verb for pmm-agent's API (#589) * SAAS-377 Disable checks by name (#588) * SAAS-377 Add API for checks disabling * SAAS-377 Make checks API consistent with other PMM APIs * SAAS-377 Eliminate types collision in swagger generated code * SAAS-377 Renaming * SAAS-377 Fix typo * SAAS-377 Renaming * SAAS-377 Refactoring * SAAS-377 Renaming * SAAS-377 Minor tweaks Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * SAAS-140 Support mongodb timestamp * trying to fix pmm-agent tests * Revert "trying to fix pmm-agent tests" This reverts commit a8239ff. * SAAS-140 Fix Timestamp, add DateTime handling Co-authored-by: Jaroslav Musil <49949480+yareach@users.noreply.github.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
BupycHuk
added a commit
that referenced
this pull request
Nov 3, 2020
* Added go 1.15.x. (#592) Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * SAAS-107 Add comments (#581) * PMM-6759 Support GET verb for pmm-agent's API (#589) * SAAS-377 Disable checks by name (#588) * SAAS-377 Add API for checks disabling * SAAS-377 Make checks API consistent with other PMM APIs * SAAS-377 Eliminate types collision in swagger generated code * SAAS-377 Renaming * SAAS-377 Fix typo * SAAS-377 Renaming * SAAS-377 Refactoring * SAAS-377 Renaming * SAAS-377 Minor tweaks Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * PMM-6746 API for PSMDB cluster. * PMM-6746 Refactoring. * PMM-6746 rename credentials field. * PMM-6746 Fix merge conflicts. * PMM-6746 Fix validation. * PMM-6746 Add Replicaset to Get response. Co-authored-by: Jaroslav Musil <49949480+yareach@users.noreply.github.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
AlekSi
added a commit
that referenced
this pull request
Nov 12, 2020
* Added go 1.15.x. (#592) Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * SAAS-107 Add comments (#581) * PMM-6759 Support GET verb for pmm-agent's API (#589) * SAAS-377 Disable checks by name (#588) * SAAS-377 Add API for checks disabling * SAAS-377 Make checks API consistent with other PMM APIs * SAAS-377 Eliminate types collision in swagger generated code * SAAS-377 Renaming * SAAS-377 Fix typo * SAAS-377 Renaming * SAAS-377 Refactoring * SAAS-377 Renaming * SAAS-377 Minor tweaks Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * PMM-6397 adds metrics flow with push and pull model, inventory api - option to enable push metrics flow, management api - 3 possible ways to define metrics_mode - auto, push and pull. * adds vmagent scrape config * adds format for metrics mode * adds format for metrics mode * changes push_metrics_disabled to push_metrics_enabled response * fixes node exporter agent response * updates comments * updates api, adds new exporters - rds and proxysql with push metrics flow fixes comments * adds vmagent agent type * removes vmagent scrape config * adds nice string * adds external exporter with push metrics * fixes external exporter api * PMM-6399 adds listen_port to agentsInfo response * PMM-6397 Minor tweaks * Port unrelated change from forgotten branch * PMM-6397 Expand/add comments * PMM-6397 Sync order * PMM-6397 Minor comments tweak Co-authored-by: Jaroslav Musil <49949480+yareach@users.noreply.github.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
yareach
added a commit
that referenced
this pull request
Nov 13, 2020
* Added go 1.15.x. (#592) Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * SAAS-107 Add comments (#581) * PMM-6759 Support GET verb for pmm-agent's API (#589) * SAAS-377 Disable checks by name (#588) * SAAS-377 Add API for checks disabling * SAAS-377 Make checks API consistent with other PMM APIs * SAAS-377 Eliminate types collision in swagger generated code * SAAS-377 Renaming * SAAS-377 Fix typo * SAAS-377 Renaming * SAAS-377 Refactoring * SAAS-377 Renaming * SAAS-377 Minor tweaks Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * PMM-4172 PT MySQL summary. * PMM-4172 Fix build. * PMM-4172 Add endpoint for mysql summary. * PMM-4172 Add params for request. * PMM-4172 Change params for request. * PMM-4172 Params. * PMM-4172 Changes. * PMM-4172 Changes. * PMM-4172 Changes. * Updated pt-mysql-summary messages comments. * [PMM-4172] Regenerated files after the comments' change. * [PMM-4172] Updated PTMySQLSummaryParams struct. * PMM-4172 Changed the PTMySQLSummaryParams message. * PMM-4172 Changed message structure's items according to AlekSi's suggestion. * PMM-4172 Changed port from string to uint32. Co-authored-by: Jaroslav Musil <49949480+yareach@users.noreply.github.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com> Co-authored-by: Jiří Čtvrtka <jiri.ctvrtka.sde@gmail.com> Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com> Co-authored-by: Jaroslav Musil <jaroslav.musil.sde@gmail.com>
artemgavrilov
pushed a commit
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.