Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add root node_modules to import commands when running pnpm #1643

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

felipeplets
Copy link
Contributor

@felipeplets felipeplets commented Jun 27, 2024

fixes 1481

This is a follow up to #1482 including the requested Unit Tests.

@pankaj443
Copy link
Contributor

pankaj443 commented Jul 3, 2024

Hey @felipeplets, there is 1 lint issue and 1 uncovered line for test coverage, please check

@felipeplets
Copy link
Contributor Author

Hey @felipeplets, there is 1 lint issue and 1 uncovered line for test coverage, please check

I have fixed both issues.

@pankaj443 pankaj443 merged commit 013d8c6 into percy:master Jul 8, 2024
36 checks passed
@felipeplets felipeplets deleted the issue-1481 branch July 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[percy] ParseError: Unexpected argument 'storybook'
2 participants