Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 4 from appveyor tests #75

Merged
merged 1 commit into from Sep 13, 2018
Merged

Conversation

@maprules1000
Copy link
Contributor

@maprules1000 maprules1000 commented Sep 13, 2018

Node 4 was removed from the travis pipeline and this removes it from the appveyor pipeline. It was causing some flakey tests because some of addons have deprecated node 4 support.

Copy link
Member

@fotinakis fotinakis left a comment

LGTM 🌮

@fotinakis fotinakis merged commit 182d240 into master Sep 13, 2018
1 of 5 checks passed
1 of 5 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
security/snyk - package.json (timhaines) No manifest changes detected
@maprules1000 maprules1000 deleted the map/remove-node-4-appveyor branch Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants