Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for seg fault #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for seg fault #23

wants to merge 1 commit into from

Conversation

jndevanshu
Copy link

The clustering algorithm seg faults when running for large files ~12GB. This commit fixes it.

@jndevanshu jndevanshu mentioned this pull request Jul 20, 2018
Open
@percyliang
Copy link
Owner

Thanks for the PR. It's been a while, but I remember there might have some reason to not use a string there for performance reasons. Is there a difference between the loading times of the two implementations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jndevanshu @percyliang