PERFFORJ-58: Update AspectJ compile dependency to 1.6.11 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, this should wait until 1.6.12 is published to Maven Central, otherwise we'll hit "Bug 341446 - java.lang.UnsupportedClassVersionError when running Java 1.5" [1] or be forced to Java 1.6 support. AspectJ 1.6.11 is effected, 1.6.12 supposedly not. |
…s in JEXL tag/message expressions.
perf4j
added a commit
that referenced
this pull request
Oct 21, 2011
PERFFORJ-59 Support executing "class" and "methodName" variable access in JEXL tag/message expressions.
|
One comment on this - note after I did the merge I ended up renaming AbstractJoinPoint.getExecutingClass to AbstractJoinPoint.getDeclaringClass - see my checkin comments on 2915510. |
|
+1 good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AspectJ compile dependency to 1.6.11