Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package for Ubuntu 16.04 Xenial #84

Closed
zokier opened this issue Apr 8, 2016 · 4 comments
Closed

Package for Ubuntu 16.04 Xenial #84

zokier opened this issue Apr 8, 2016 · 4 comments

Comments

@zokier
Copy link
Contributor

zokier commented Apr 8, 2016

There are Bintray packages for older Ubuntu versions, but not for the upcoming new 16.04. Because Xenial includes only Python 3 in default install, now would be a good time to make the packages fully Python 3 based/compatible to reduce dependencies, especially as per my understanding PCP itself is already Python 3 compatible.

The final release of 16.04 is scheduled to happen April 21st.

@zokier
Copy link
Contributor Author

zokier commented Apr 9, 2016

I made the Ubuntu package Python3 based, here is the diff: master...zokier:xenial . Note that I haven't tested the packages very thoroughly, but it seems to work fine for me.

I noticed that the package is built with --without-systemd. Now that both Debian and Ubuntu are systemd based, it probably would be a good idea to change that? I'm not sure what is needed to systemdify the package otherwise.

@natoscott
Copy link
Member

@zokier thanks for the info & patch!

The patch takes the approach of removing the python2 support - could you change it to support both python2 and python3 side-by-side? (IOW, build depend on both, and generate both a python-pcp and a python3-pcp deb package)

I'll attempt to get a 16.04 bintray build in place for the next PCP release (http://pcp.io/roadmap - timing looks good from the dates you gave).

@natoscott
Copy link
Member

@zokier oh, regarding systemd:

I noticed that the package is built with --without-systemd.

This is fairly well tested on Fedora and RHEL7 now. For Debian builds, it's a matter of enabling that build option, updating the debian packaging (like you did for python3) and testing the resulting debs.

cheers.

@natoscott
Copy link
Member

(Merged modified support for py2 & py3 side-by-side.)

natoscott added a commit to natoscott/pcp that referenced this issue Sep 7, 2022
…8f460da..65fc7b81f3

65fc7b81f3 Release 0.8.1
a63aa04fed Fix async api issues (performancecopilot#107)
a439a20f4f No command retries due to CROSSSLOT
b96d43fd95 Connect using redisConnectWithOptions() (performancecopilot#103)
c47e8a9cf3 Update hiredis version in build examples
0a3b20f691 Update Makefile
4a581e91e4 Use common build warnings
08ffdd30f0 Remove usage of hiredis internal flags (performancecopilot#101)
f3091fef52 Release 0.8.0 (performancecopilot#99)
0e741c6dd8 Add Redis compatibility testing to CI (performancecopilot#97)
1aa93a0862 Add crude support for BITFIELD and BITFIELD_RO (performancecopilot#96)
295bf3c81e Add async transaction tests
6c0aecfcf1 Deprecate non-block options which have no effect (performancecopilot#89)
16ec08bb8b Accept multiple field and value arguments in HSET (performancecopilot#86)
ff76aac0f5 Timeout tests and corrections (performancecopilot#84)
7c39940fa9 Move SSL support to own library (performancecopilot#80)
573c1006f9 README updates (performancecopilot#81)
e642e42df1 Add windows and macOS builds to CI (performancecopilot#76)
5c9e294f75 tests: fix error handling in clusterclient_reconnect_async (performancecopilot#70)
4a69cb65d1 tests: add reconnect test (performancecopilot#68)
512a790dad reset cluster context errors in redisClusterAsyncFormattedCommandToNode

git-subtree-dir: vendor/github.com/Nordix/hiredis-cluster
git-subtree-split: 65fc7b81f31389b878a669710bac9d7042c2404b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants