Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmda-smart read almost no metrics, parsing of new smartmon format #901

Closed
christianhorn opened this issue May 4, 2020 · 2 comments
Closed
Assignees

Comments

@christianhorn
Copy link
Collaborator

For nvme SSD's on multiple systems (Fedora 31, 32), I just get these metrics from pmda-smart:
smart.health
smart.info.device_model
smart.info.serial_number
smart.info.capacity_bytes
smart.info.sector_size
smart.info.rotation_rate

From looking at qa/smart/smart-root*, it seems like the output of "smartctl -a" has changed since the pmda was written. The QA suite was simply always using the data from the older versions, and did not catch this.

@pauljevans
Copy link
Collaborator

@christianhorn, could you post the output of "lsblk" along the outputs from "smartctl -Hi" and "smarctl -A" from one of the systems that you are seeing issues with?

@christianhorn
Copy link
Collaborator Author

pmda_smart.txt

natoscott pushed a commit that referenced this issue Aug 4, 2020
Add support in the S.M.A.R.T PMDA for health attributes from NVME disks
using smartctl output and following the attributes listed in the NVME
Express 1.4a Specification.

It turns out that SATA SSD and NVM Express SSD have completely different
S.M.A.R.T listing in both attributes and format. This patch add the support
along with new "smart.nvme_attributes.*" metrics.

Included is an updated and expanded QA test 1379 that covers testing an
NVME disk input and Valgrind testing.

This update satisfies github issue #901 "pmda-smart read almost no
metrics..."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants