Feature/guitar chords #796
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use forward declaration of Analyzer to prevent to much recompiling.
twollgam
force-pushed
the
feature/GuitarChords
branch
from
2ac7998
to
3ea52ae
Compare
|
Download the artifacts for this pull request:
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time. |
twollgam
force-pushed
the
feature/GuitarChords
branch
2 times, most recently
from
3a9264d
to
2de32a9
Compare
The class represents all frequencies of a chord and alternatives. Add more fft tests.
twollgam
force-pushed
the
feature/GuitarChords
branch
from
b36062e
to
ff6c218
Compare
The ogg files are not loaded correct. So that currently the raw (.f32) versions are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will add a new feature of playing guitar chords. This requires a real guitar plugged to the computer.
Chords will be displayed on the screen like text. The guitar playing is analyzed by performous via fft and it will be rated like singing.
Closes Issue(s)
None, may close #126
Motivation
I want to sing and play guitar chord together in one game.
More
Additional Notes
Draft pull request cause it is a lot of work.