Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize queries for projects with many deployments. #38

Closed
wants to merge 2 commits into from
Closed

Optimize queries for projects with many deployments. #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b37fc7
Optimize some queries for when there are a lot of deployments.
ngan Aug 10, 2011
9ecbdaf
Use ActiveRecord::Base#exists? instead of first.
ngan Aug 10, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/models/role.rb
View file
Open in desktop
Expand Up @@ -78,17 +78,17 @@ def unset_no_symlink!

# tells if this role had a successful setup
def setup_done?
deployed_at_least_once? && self.deployments.any?{|x| Deployment::SETUP_TASKS.include?(x.task) && x.success? }
deployed_at_least_once? && self.deployments.exists?(:conditions => {"deployments.task" => Deployment::SETUP_TASKS, "deployments.status" => Deployment::STATUS_SUCCESS})
end

# tells if this role had a successful deployment (deploy)
def deployed?
deployed_at_least_once? && self.deployments.any?{|x| Deployment::DEPLOY_TASKS.include?(x.task) && x.success? }
deployed_at_least_once? && self.deployments.exists?(:conditions => {"deployments.task" => Deployment::DEPLOY_TASKS, "deployments.status" => Deployment::STATUS_SUCCESS})
end

# tells if this role had any deployment at all
def deployed_at_least_once?
!self.deployments.empty?
self.deployments.exists?
end

def status
Expand Down