New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publisher: error displaying files in sha224 parents #1292
Comments
@tajtiattila thanks. do you want to have a go at fixing it? |
@mpl This seems fairly trivial to fix, so I modified getFullRef and its call site in app/publisher/js/file.go to use a logical constraint with both ssh224 and ssh1 in the prefix. Unfortunately, I'm on Windows and I couldn't get it to build the Web UI yet. Maybe we should have a Dockerfile to do just that. |
Fixes perkeep#1292 Change-Id: I77fd44b97b8643a2ef037ffa51577f5d3e42327e
I've updated with your fix the generated publisher.js that we host , for when one wants to run make.go without regenerating the webUI. It seems there's some caching shenanigans going on at the moment though. I'll recheck tomorrow. |
When a published container uses a sha224 hash, its page with thumbnails is displayed in publisher correctly, but file links don't work because of the hardcoded "sha1-" prefix in the call of getFullRef in newFileItemContainer of app/publisher/js/file.go.
The text was updated successfully, but these errors were encountered: