Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app/publisher template expansion broken with html/template in Go 1.9 #960

Closed
khimaros opened this issue Sep 28, 2017 · 3 comments
Closed

app/publisher template expansion broken with html/template in Go 1.9 #960

khimaros opened this issue Sep 28, 2017 · 3 comments
Assignees
@mpl

Comments

@khimaros
Copy link

After rebuilding from latest in master branch with Go 1.9 and attempting to hit one of my published endpoints:

2017-09-28T05:43:28.699206699Z PUBLISHER: 2017/09/28 05:43:28 Error serving subject template: html/template:subject:28:50: predefined escaper "html" disallowed in template

The error appears to be referring to https://github.com/camlistore/camlistore/blob/master/app/publisher/gallery.html#L28

Root cause appears to be: https://go-review.googlesource.com/c/go/+/37880 -- which appears to have been wrapped into Go 1.9.
@mpl
Copy link
Contributor

mpl commented Sep 28, 2017

thanks, I'm on it.

@mpl mpl self-assigned this Sep 28, 2017
@mpl
Copy link
Contributor

mpl commented Sep 28, 2017

@sllawap PTAL: https://camlistore-review.googlesource.com/c/camlistore/+/11386

@mpl mpl mentioned this issue Sep 28, 2017
Closed
@khimaros
Copy link
Author

Thanks @mpl -- it works!

camlistorebot pushed a commit that referenced this issue Sep 28, 2017
@mpl
app/publisher: remove now disallowed html escaper from template
683fa35 
Apparently the html escaper was not being used in the right order/place,
and the auto-escaper does a better job than us at escaping?

For reference: https://go-review.googlesource.com/c/go/+/37880

I have noticed some odd results when trying other escaping combinations,
but that's a Go problem, if any, that I will investigate independently.

Fixes #960

Change-Id: I43e6eca26404d0bcbc7a48764393186f1d112dbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpl mpl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khimaros @mpl