Refactor parse_dsn() #143
Closed
Refactor parse_dsn() #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During global destruction phase ChildHandles DBI attribute may be already released or children can be undefs due to weakrefs. So instead of relaying on ChildHandles, maintain own double linked list of all imp_dbh structures with active MYSQL connection. This does not use any Perl data structures so they are available at any time, including global destruction phase. Fixes: jhthorsen/mojo-mysql#47 (comment) Fixes: 17d5aa0
This simplify implementation of taken_pmysqls.
Sometimes CREATE TABLE statement throws following error: Deadlock found when trying to get lock; try restarting transaction
Function mariadb_st_execute_iv() did not reset current row, so next mariadb_st_fetch() function call returned nothing if previously all data were already fetched. Now execute() reset current row to first one so fetch function starts fetching from beginning. This fixes usage of $dbh->prepare_cached() method, specially in construction like this: $dbh->selectcol_arrayref($dbh->prepare_cached(...)) Fixes: 4f47a06
skip_all doesn't skip assertions in the END block.
This reverts commit 5f3272e. MySQL bug #93276 is not fixed in 8.0.15 yet. Fixes: perl5-dbi#137 See: https://bugs.mysql.com/bug.php?id=93276
|
This look like a wrong rebase. The PR should only contain the last two commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was originally from #132.