Refactor of parse_dsn() #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the new test is missing in the manifest. |
pali
reviewed
Mar 21, 2019
| my %attrs_localhost_test = ( | ||
| database => 'test', | ||
| host => 'localhost', | ||
| port => 3306, |
There was a problem hiding this comment.
localhost is local unit socket, so port option cannot be used together with localhost.
|
Also, you have opened this change in 3 different pull requests. Please update code in existing pull request and do not open new one. One change with whole review should be in one pull request. |
|
@rkleemann could you fix the issues mentioned above in the review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this in place of #132 or #143