Improve SSL settings, reflect changes for BACKRONYM and Riddle vulnerabilities, enforce SSL encryption when mysql_ssl=1 is set #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pali
force-pushed
the
ssl
branch
2 times, most recently
from
ac5bed1
to
ee27812
Compare
This reflect changes between different versions of libmysqlclient.so and finally fix library usage to handle BACKRONYM and Riddle vulnerabilities. Due to fixing vulnerabilities, it changes also behavior of mysql_ssl=1 attribute from opportunistic mode to enforced mode of SSL. Now DBD::mysql with mysql_ssl=1 fails to connect to non-SSL server.
When set, SSL encryption is not enforced and allow DBD::mysql to fallback to plain text protocol if server does not support SSL. Older MySQL and MariaDB client versions does not support enforced SSL mode due to BACKRONYM and Riddle vulnerabilities.
pali
changed the title
It returns SSL encryption cipher or undef if SSL is not used. It can be used by application to check if SSL was established or not.
pali
force-pushed
the
ssl
branch
3 times, most recently
from
fe37eab
to
d36a5a6
Compare
|
This should be reopened now that master got reverted back to 4.041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improve SSL settings by:
The important change is that DBD::mysql reject connection to MySQL server (also SSL enabled) if mysql_ssl=1 is set and libmysqlclient.so library cannot enforce SSL encryption (because is vulnerable to BACKRONYM or Riddle).
See also discussion at #110