Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix anchor link #82

Merged
merged 1 commit into from
Nov 20, 2015
Merged

fix anchor link #82

merged 1 commit into from
Nov 20, 2015

Conversation

rjbs
Copy link
Contributor

@rjbs rjbs commented May 15, 2015

The old link was to #Object Construction but the live page has an underscore in place of space.

The old link was to `#Object Construction` but the live page has an underscore in place of space.
@moritz
Copy link
Collaborator

moritz commented May 15, 2015

Since the heading doesn't use an underscore either, IMHO it would be a good idea to fix the tooling instead of generate the correct URL from the link without the underscore

@zoffixznet
Copy link
Contributor

I've came across this PR many times, but just now realized that we can't fix the tooling for this case for these reasons:

  1. The hash of the URL comes from an id attribute, which is forbidden to have space characters in it
  2. Even if those were allowed, they are not allowed to be non-encoded in URLs, which would make writing the URLs harder ( ->%20), and they'd also look uglier.

@zoffixznet zoffixznet merged commit 0284491 into Raku:master Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants