Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API::Discord to ecosystem #406

Merged
merged 3 commits into from Oct 27, 2018
Merged

Add API::Discord to ecosystem #406

merged 3 commits into from Oct 27, 2018

Conversation

kawaii
Copy link
Member

@kawaii kawaii commented Aug 22, 2018

https://github.com/shuppet/p6-api-discord

Thank you for submitting a module to the Perl 6 Ecosystem!

Uploading Perl 6 modules to CPAN is the preferred way of distributing modules, since GitHub is not a CDN. If you have the option, please use that route instead of adding the module here.

If adding a new module please review the following check boxes and check the appropriate boxes by going to the preview tab and checking them interactively or alternatively replacing the space in the checkboxes with an X. Your work is appreciated and every module helps make the Perl 6 Ecosystem a bigger and better place ♥

@Altai-man
Copy link
Member

Hello. Thanks for your contribution! 👍

Please note that there are no Cro::WebSocket::Client module, it is named Cro::WebSocket and in provides section it provides Cro::WebSocket::Client among others. Please fix the dependency so your module could be install-able by other users.

@Altai-man
Copy link
Member

I have sent a PR at shuppet/raku-api-discord#7

@Altai-man
Copy link
Member

Seems like a bit more of work, please see shuppet/raku-api-discord#9

@Skarsnik
Copy link
Contributor

Skarsnik commented Aug 23, 2018 via email

@zoffixznet
Copy link
Contributor

Hi,

What's happening with this PR? Should it be merged? Should it be closed?

@Altai-man
Copy link
Member

@zoffixznet the module is still not install-able. I have opened a new PR and updated an issue at shuppet/raku-api-discord#9
ping @kawaii ?

@zoffixznet
Copy link
Contributor

zoffixznet commented Oct 27, 2018

That shouldn't hold this PR open though, should it? There are merge conflicts now, for example.

@zoffixznet zoffixznet merged commit fb68263 into Raku:master Oct 27, 2018
@zoffixznet
Copy link
Contributor

👍 Thanks!

@JJ
Copy link
Contributor

JJ commented Oct 27, 2018 via email

@kawaii kawaii deleted the patch-1 branch October 29, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants