Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(many) Upgrade to .NET 6 #223

Merged
merged 1 commit into from
Nov 11, 2021
Merged

(many) Upgrade to .NET 6 #223

merged 1 commit into from
Nov 11, 2021

Conversation

perlun
Copy link
Collaborator

@perlun perlun commented Nov 5, 2021

No description provided.

.github/workflows/dotnetcore.yml Show resolved Hide resolved
@@ -2,7 +2,8 @@
<!-- C# analyzers configuration -->
<PropertyGroup>
<CodeAnalysisRuleSet>$(SolutionDir)global.ruleset</CodeAnalysisRuleSet>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppressing trimmer analysis warnings might seem a bit foolish, but I'm not sure littering the code with tons of attributes to suppress them is really the way forward for us. Let's for now assume the "dynamic programming language" approach instead - let's catch errors with unit tests instead of static analysis. 🤪

Time will tell whether this is insane or simply a stroke of genius...

Copy link
Collaborator Author

@perlun perlun Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time will tell whether this is insane or simply a stroke of genius...

Well. It hit us in #347, making these trimming warnings be invisible by default... 😎 See #347 (comment).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to solve this. Created an issue to track the work related to it: #348

@perlun perlun changed the title (ci) Build with .NET 6 (many) Upgrade to .NET 6 Nov 11, 2021
@perlun perlun merged commit 9480f21 into master Nov 11, 2021
@perlun perlun deleted the feature/build-on-net-6 branch November 11, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI-related issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant