(interpreter) Fix integer expansions to bigint
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
commented
Nov 22, 2021
| // TODO: Might need to revisit this to support more types as we implement #70. | ||
| _ => throw new IllegalStateException($"Unsupported conversion from {value.GetType().ToTypeKeyword()} to {targetTypeReference.ClrType.ToTypeKeyword()}") | ||
| }; | ||
| } |
There was a problem hiding this comment.
☝️ This is the essence of the fix.
Also, the TODO comment for #70 is quite important. The easiest way to ensure that it gets fixed is probably to add more test cases, so that we properly test this with values of all types expected to be supported (i.e. expanding this list as we support more types, uint, ulong and potentially decimal - there are BigInteger constructors for all of these that could be used).
perlun
commented
Nov 22, 2021
| public void exponential_integer_literals_as_variable_initializer() | ||
| [Theory] | ||
| [InlineData("2", "12", "4096")] | ||
| [InlineData("10", "3.5", "3162")] // TODO: Fix this once the `dynamic` PR gets merged. This is incorrectly coerced to BigInteger in the current implementation. |
There was a problem hiding this comment.
🙈 The correct value here would be something like 3162.2776601683795.
perlun
changed the title
bigint
perlun
changed the title
bigintdouble expansions to bigint
perlun
changed the title
double expansions to bigintbigint
|
For reference, the semantics after this MR got merged was insane: (Using a This was corrected in #237: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #225, I discovered that some semantics here was essentially broken. The exponential operator only worked properly with
int+intorbigint+intoperands. When one of the operands was afloat, it was impossible to assign the result to a variable.