Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(stdlib) Add C++-based stdlib project #407

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

perlun
Copy link
Collaborator

@perlun perlun commented Sep 1, 2023

This is part of the overall #406 issue (Implement compiled mode for Perlang). Not ready for merge, but we're getting there, slowly but steadily...

@perlun perlun added enhancement New feature or request experimental compilation Issues which are relevant when using experimental compilation labels Sep 1, 2023
@perlun perlun added this to the 0.4.0 milestone Sep 1, 2023
@perlun
Copy link
Collaborator Author

perlun commented Sep 1, 2023

(The CI failure is because of #398; we might have to disable the install_windows job in CI for now.)

README.md Show resolved Hide resolved
{
fmt::println("{}", d);
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ This is one of the more important parts in this PR. It features the implementation of the perlang::print() methods, with various overloads for the different primitive types we support.

@perlun perlun force-pushed the feature/add-cpp-stdlib branch 4 times, most recently from 9d8b80d to 7afea32 Compare September 26, 2023 19:08
# (PERLANG_EXPERIMENTAL_COMPILATION=true)
- name: Rebuild stdlib
run: make stdlib

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs the compilation of the stdlib. We could also run the tests, but they are not fully working yet (and even when they are, there will be some more work to get them working on macOS). Let's see if we merge this now already or if we fix this first.

CcTest* prev_;
};

#endif // ifndef CCTEST_H_
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let's be a bit lazy and use the cctest test helper from https://github.com/google/double-conversion. In the long run, we should switch to https://github.com/catchorg/Catch2.

@perlun perlun force-pushed the feature/add-cpp-stdlib branch 2 times, most recently from e1e30ae to db46411 Compare September 26, 2023 19:40
@perlun perlun enabled auto-merge (squash) September 27, 2023 19:18
@perlun perlun merged commit d66c6a4 into master Sep 27, 2023
13 checks passed
@perlun perlun deleted the feature/add-cpp-stdlib branch September 27, 2023 19:21
@perlun perlun mentioned this pull request Oct 1, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experimental compilation Issues which are relevant when using experimental compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant