errno is no longer zero coming out of IO::AIO

As of IO::AIO 3.7, you have to actually read the return code.
perlbal · Jun 8, 2011 · 3031ab7 · 3031ab7
1 parent ec07ca0
commit 3031ab7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/Perlbal/ClientHTTP.pm b/lib/Perlbal/ClientHTTP.pm
@@ -294,7 +294,7 @@ sub handle_delete {
         # now attempt the unlink
         Perlbal::AIO::aio_unlink($self->{service}->{docroot} . '/' . $uri, sub {
             my $err = shift;
-            if ($err == 0 && !$!) {
+            if ($err == 0) {
                 # delete was successful
                 return $self->send_response(204);
             } elsif ($! == ENOENT) {

diff --git a/lib/Perlbal/ClientProxy.pm b/lib/Perlbal/ClientProxy.pm
@@ -1207,7 +1207,7 @@ sub purge_buffered_upload {
     eval {
         # now asynchronously unlink the file
         Perlbal::AIO::aio_unlink($self->{bufilename}, sub {
-            if ($!) {
+            if ($_[0] != 0 && $!) {
                 # note an error, but whatever, we'll either overwrite the file later (O_TRUNC | O_CREAT)
                 # or a cleaner will come through and do it for us someday (if the user runs one)
                 Perlbal::log('warning', "Unable to link $self->{bufilename}: $!");