Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to urfave/cli for the shell, added autocompletion, some 80 col changes. #121

Merged
merged 10 commits into from
Jul 27, 2019
Merged

Changed to urfave/cli for the shell, added autocompletion, some 80 col changes. #121

merged 10 commits into from
Jul 27, 2019

Conversation

diamondburned
Copy link
Contributor

  • Changed shell command evaluation to urfave/cli
    • Command help is different
    • Quotes are done properly now
  • Added autocompletion
  • Changed shell.go to cli.go
  • Moved the actions to actions.go so cli.go isn't too long
  • cmd/wavelet files have some lines changed so they're not too long
  • Fixed cmd/wavelet/README.md
  • Tidied go.mod

iwasaki-kenta
iwasaki-kenta reviewed Jun 29, 2019
View reviewed changes
cmd/wavelet/cli.go Outdated Show resolved Hide resolved
@hasyimibhar hasyimibhar mentioned this pull request Jul 17, 2019
Closed
@diamondburned diamondburned changed the base branch from master to cli July 18, 2019 09:38
@iwasaki-kenta iwasaki-kenta changed the base branch from cli to master July 18, 2019 14:03
@iwasaki-kenta iwasaki-kenta changed the title Changed to urfave/cli for the shell, added autocompletion, some 80 col changes Changed to urfave/cli for the shell, added autocompletion, some 80 col changes. Jul 27, 2019
iwasaki-kenta
iwasaki-kenta approved these changes Jul 27, 2019
View reviewed changes
Copy link
Contributor

@iwasaki-kenta iwasaki-kenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iwasaki-kenta iwasaki-kenta merged commit 67033d2 into perlin-network:master Jul 27, 2019
losfair added a commit that referenced this pull request Aug 6, 2019
@losfair
Revert "Changed to urfave/cli for the shell, added autocompletion, so…
b70b5e4 
…me 80 col changes. (#121)"

This reverts commit 67033d2.
iwasaki-kenta pushed a commit that referenced this pull request Aug 6, 2019
@losfair @iwasaki-kenta
Preserve globals of smart contracts into account state. (#151)
0c18e67 
* Revert "Changed to urfave/cli for the shell, added autocompletion, some 80 col changes. (#121)"

This reverts commit 67033d2.

* sys/const, contract, db: Preserve globals for contracts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwasaki-kenta iwasaki-kenta iwasaki-kenta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diamondburned @iwasaki-kenta