Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize mat inv compute null space #23

Merged
merged 5 commits into from
May 28, 2020
Merged

generalize mat inv compute null space #23

merged 5 commits into from
May 28, 2020

Conversation

haplav
Copy link
Collaborator

@haplav haplav commented Apr 30, 2020 •
edited
Loading

Fix #21.

@haplav haplav linked an issue Apr 30, 2020 that may be closed by this pull request
MatInvComputeNullSpace() supports only MATBLOCKDIAG input matrix #21
Closed
@haplav haplav mentioned this pull request Apr 30, 2020
Draft
@jkruzik jkruzik mentioned this pull request May 5, 2020
Open
jkruzik
jkruzik reviewed May 5, 2020
View reviewed changes
src/mat/impls/inv/matinv.c Outdated Show resolved Hide resolved
@haplav haplav force-pushed the haplav/generalize-MatInvComputeNullSpace branch 2 times, most recently from 039aa94 to 36024d5 Compare May 6, 2020 22:55
@haplav haplav changed the base branch from master to TEMP-BASE-haplav/generalize-MatInvComputeNullSpace May 6, 2020 22:55
@haplav
Copy link
Collaborator Author

haplav commented May 6, 2020

This is now blocked by #28, #29, #30.

@haplav haplav mentioned this pull request May 8, 2020
Open
@haplav
Copy link
Collaborator Author

haplav commented May 21, 2020

This is now blocked by #28, #29, #30.

OK, blocking PRs have been merged.

@haplav haplav closed this May 26, 2020
@haplav
Copy link
Collaborator Author

haplav commented May 26, 2020

Closed by accident. GitHub is stupid here, it closed the PR automatically because the base branch got deleted. This does not happen on GitLab.

@haplav
Copy link
Collaborator Author

haplav commented May 26, 2020

OK, reverted (force pushed again) base and feature branches, and now I can reopen.

@haplav haplav reopened this May 26, 2020
@haplav haplav force-pushed the haplav/generalize-MatInvComputeNullSpace branch from 36024d5 to a995615 Compare May 26, 2020 16:01
@haplav haplav changed the base branch from TEMP-BASE-haplav/generalize-MatInvComputeNullSpace to master May 26, 2020 16:02
@haplav
Copy link
Collaborator Author

haplav commented May 26, 2020 •
edited
Loading

  • haplav/generalize-MatInvComputeNullSpace rebased onto master
  • TEMP-BASE-haplav/generalize-MatInvComputeNullSpace deleted.

@haplav haplav force-pushed the haplav/generalize-MatInvComputeNullSpace branch from a995615 to e94befd Compare May 26, 2020 16:11
@haplav haplav changed the title WIP: generalize mat inv compute null space generalize mat inv compute null space May 26, 2020
@haplav haplav marked this pull request as ready for review May 26, 2020 16:12
@haplav
Copy link
Collaborator Author

haplav commented May 26, 2020

@jkruzik This is ready for your review. Tests are clean on my machine.

jkruzik
jkruzik reviewed May 28, 2020
View reviewed changes
src/mat/impls/inv/matinv.c Show resolved Hide resolved
src/mat/interface/permonmatutils.c Show resolved Hide resolved
src/mat/impls/inv/matinv.c Show resolved Hide resolved
@haplav @jkruzik
Apply suggestions from code review
646b6cd 
Co-authored-by: Jakub Kruzik <jakub.kruzik@gmail.com>
@haplav
Copy link
Collaborator Author

haplav commented May 28, 2020

OK, @jkruzik approvable now?

jkruzik
jkruzik approved these changes May 28, 2020
View reviewed changes
src/mat/interface/permonmatutils.c Show resolved Hide resolved
@haplav haplav merged commit f432d67 into master May 28, 2020
@haplav haplav deleted the haplav/generalize-MatInvComputeNullSpace branch May 28, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkruzik jkruzik jkruzik approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatInvComputeNullSpace() supports only MATBLOCKDIAG input matrix
2 participants
@haplav @jkruzik