Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow visualizing the dashboard's JSON in read mode #1651

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Dec 15, 2023

Description

The button to access the dashboard's JSON in the toolbar is now accessible in read mode too, allowing the users to view the JSON definition of the dashboard without being able to edit it.

Screenshots

2023-12-15_15h52_23.mp4

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud marked this pull request as ready for review December 15, 2023 16:09
Copy link
Member

@Gladorme Gladorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@AntoineThebaud AntoineThebaud added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 3b29424 Dec 15, 2023
18 of 19 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/json-read-view branch December 15, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants