Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Auto input resize for text variables #1654

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Dec 18, 2023

Description

Implement dynamic input resize for Text variables, as it was done for List variables in #1576.

As in this past PR, the computed input size doesn't perfectly fit the text content due to the approximation done to consider that each character = 8px. It's still better than before but could for sure be improved.

Screenshots

2023-12-18_11h29_01.mp4

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@AntoineThebaud AntoineThebaud marked this pull request as ready for review December 18, 2023 10:35
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

Co-authored-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

Co-authored-by: Augustin Husson <husson.augustin@gmail.com>
@AntoineThebaud AntoineThebaud added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 20a69c0 Dec 22, 2023
18 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/text-var-resize branch December 22, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants