[ENHANCEMENT] Replace DaC init script by percli dac setup
#1695
Conversation
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
AntoineThebaud
force-pushed
the
antoinethebaud/DaC-part2
branch
from
fecf2e1
to
360937d
Compare
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
AntoineThebaud
changed the title
AntoineThebaud
changed the title
percli dac setup
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
| return persesCMD.Run(o, cmd, args) | ||
| }, | ||
| } | ||
| cmd.Flags().StringVar(&o.version, "version", "", "Version of Perses from which to retrieve the CUE dependencies.") |
There was a problem hiding this comment.
I'm wondering if we should manage the setup for the go sdk as well here. That's kind of weird from my point of view the command dac init would support only one language
There was a problem hiding this comment.
IMHO better to keep it simple thus CUE-opinionated for now, and to refactor with a next PR when we'd want to make it work with the Go SDK, but that's a matter of preference I guess.
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
| return nil | ||
| } | ||
|
|
||
| func (o *option) Validate() error { |
There was a problem hiding this comment.
what do you think about checking if the binary cue is accessible. I'm thinking also we could provide a flag that will give us the path to the binary cue. So you can point exactly what binary you want to use and also in case cue is not in the PATH
There was a problem hiding this comment.
Let's do that in a different PR. It's actually not that simple.
Description
dac_setup.shscript replaced by a new CLI commandpercli dac setup.Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.